Migrate DevToolsWindow from specific to opaque frontend host messages

Migrate DevToolsWindow from specific to opaque frontend host messages

TBR=jam (new file in chrome.gyp) 
BUG=278002
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221418

[pfeldman, 2013-08-23 11:29:43]

lgtm

https://codereview.chromium.org/22972007/diff/1/chrome/browser/devtools/list_...
File chrome/browser/devtools/list_value_parser.h (right):

https://codereview.chromium.org/22972007/diff/1/chrome/browser/devtools/list_...
chrome/browser/devtools/list_value_parser.h:12: namespace internal {
Use anonymous namespace

[Vladislav Kaznacheev, 2013-08-23 13:44:17]

https://codereview.chromium.org/22972007/diff/1/chrome/browser/devtools/list_...
File chrome/browser/devtools/list_value_parser.h (right):

https://codereview.chromium.org/22972007/diff/1/chrome/browser/devtools/list_...
chrome/browser/devtools/list_value_parser.h:12: namespace internal {
On 2013/08/23 11:29:43, pfeldman wrote:
> Use anonymous namespace

Done.

[Vladislav Kaznacheev, 2013-09-02 11:49:20]

Hello OWNERS,

joi@, please review content/public/browser/devtools_frontend_host_delegate.h and

content/common/devtools_messages.h

pfeldman@, please review the whole patch.

Thanks,

  Vlad

[Jói, 2013-09-02 12:20:37]

> joi@, please review content/public/browser/devtools_frontend_host_delegate.h
and
> 
> content/common/devtools_messages.h

LGTM

On 2013/09/02 11:49:20, Vladislav Kaznacheev wrote:
> Hello OWNERS,
> 
> joi@, please review content/public/browser/devtools_frontend_host_delegate.h
and
> 
> content/common/devtools_messages.h
> 
> pfeldman@, please review the whole patch.
> 
> Thanks,
> 
>   Vlad

[Vladislav Kaznacheev, 2013-09-02 12:34:06]

Hello Tom,

Please review content/common/devtools_messages.h

Thanks,

  Vlad

[pfeldman, 2013-09-02 12:36:41]

lgtm

[Tom Sepez, 2013-09-03 17:34:53]

Are you replacing N explicitly typed messages with one that tunnels the actual
parameters inside a string? If so, that's a step in the wrong direction from an
auditability point of view.  We ask that you not do this.

[Tom Sepez, 2013-09-03 17:39:18]

Especially in light of introducing your own new templating mechanism in
list_value_parser which does what the IPC layer would have done for you. Not
lgtm.

[pfeldman, 2013-09-03 18:06:59]

As agreed with Tom offline, to remove the security block from this change, we
need to:

- extract dispatcher where messages land into a separate file
- make it clear that all messages are coming from the isolated
chrome-devtools:// renderer
- make it per-file =set noparent, with the owners from the per-file
*_messages*.h in content/common/OWNERS

[Vladislav Kaznacheev, 2013-09-04 09:54:42]

On 2013/09/03 18:06:59, pfeldman wrote:
> As agreed with Tom offline, to remove the security block from this change, we
> need to:
> 
> - extract dispatcher where messages land into a separate file
> - make it clear that all messages are coming from the isolated
> chrome-devtools:// renderer
> - make it per-file =set noparent, with the owners from the per-file
> *_messages*.h in content/common/OWNERS

Done. PTAL

[pfeldman, 2013-09-04 15:42:05]

Patch set #4 lgtm

[Tom Sepez, 2013-09-04 16:36:28]

LGTM.

[commit-bot: I haz the power, 2013-09-05 06:43:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/22972007/18001

[commit-bot: I haz the power, 2013-09-05 06:55:36]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-09-05 08:25:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/22972007/13001

[commit-bot: I haz the power, 2013-09-05 14:29:31]

Change committed as 221418