Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 22972007: Migrate DevToolsWindow from specific to opaque frontend host messages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_window.h ('k') | chrome/chrome.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index d052d14dbf413c7d99c3a4f5ded12d9bafc4fccb..f8e1b6a769f5171fb8211b2c4d185f1b12cc4868 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -587,6 +587,9 @@ DevToolsWindow::DevToolsWindow(Profile* profile,
if (inspected_rvh)
inspected_contents_observer_.reset(new InspectedWebContentsObserver(
content::WebContents::FromRenderViewHost(inspected_rvh)));
+
+ embedder_message_dispatcher_.reset(
+ new DevToolsEmbedderMessageDispatcher(this));
}
// static
@@ -832,6 +835,10 @@ void DevToolsWindow::WebContentsFocused(content::WebContents* contents) {
inspected_browser->window()->WebContentsFocused(contents);
}
+void DevToolsWindow::DispatchOnEmbedder(const std::string& message) {
+ embedder_message_dispatcher_->Dispatch(message);
+}
+
void DevToolsWindow::ActivateWindow() {
if (IsDocked() && GetInspectedBrowserWindow())
web_contents_->GetView()->Focus();
@@ -839,10 +846,6 @@ void DevToolsWindow::ActivateWindow() {
browser_->window()->Activate();
}
-void DevToolsWindow::ChangeAttachedWindowHeight(unsigned height) {
- NOTREACHED(); // TODO(dgozman): This is not used anymore, remove.
-}
-
void DevToolsWindow::CloseWindow() {
DCHECK(IsDocked());
content::DevToolsManager::GetInstance()->ClientHostClosing(
« no previous file with comments | « chrome/browser/devtools/devtools_window.h ('k') | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698