Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: content/browser/devtools/devtools_frontend_host.cc

Issue 22972007: Migrate DevToolsWindow from specific to opaque frontend host messages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/devtools_frontend_host.h ('k') | content/common/devtools_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_frontend_host.cc
diff --git a/content/browser/devtools/devtools_frontend_host.cc b/content/browser/devtools/devtools_frontend_host.cc
index 8f177b6941c956d52db1189e8df23a8d56dce5f8..bfa623a140ea327a4f9ae13ff57bf31dd0d0b8f6 100644
--- a/content/browser/devtools/devtools_frontend_host.cc
+++ b/content/browser/devtools/devtools_frontend_host.cc
@@ -63,23 +63,8 @@ bool DevToolsFrontendHost::OnMessageReceived(
IPC_BEGIN_MESSAGE_MAP(DevToolsFrontendHost, message)
IPC_MESSAGE_HANDLER(DevToolsAgentMsg_DispatchOnInspectorBackend,
OnDispatchOnInspectorBackend)
- IPC_MESSAGE_HANDLER(DevToolsHostMsg_ActivateWindow, OnActivateWindow)
- IPC_MESSAGE_HANDLER(DevToolsHostMsg_ChangeAttachedWindowHeight,
- OnChangeAttachedWindowHeight)
- IPC_MESSAGE_HANDLER(DevToolsHostMsg_CloseWindow, OnCloseWindow)
- IPC_MESSAGE_HANDLER(DevToolsHostMsg_MoveWindow, OnMoveWindow)
- IPC_MESSAGE_HANDLER(DevToolsHostMsg_RequestSetDockSide,
- OnRequestSetDockSide)
- IPC_MESSAGE_HANDLER(DevToolsHostMsg_OpenInNewTab, OnOpenInNewTab)
- IPC_MESSAGE_HANDLER(DevToolsHostMsg_Save, OnSave)
- IPC_MESSAGE_HANDLER(DevToolsHostMsg_Append, OnAppend)
- IPC_MESSAGE_HANDLER(DevToolsHostMsg_RequestFileSystems,
- OnRequestFileSystems)
- IPC_MESSAGE_HANDLER(DevToolsHostMsg_AddFileSystem, OnAddFileSystem)
- IPC_MESSAGE_HANDLER(DevToolsHostMsg_RemoveFileSystem, OnRemoveFileSystem)
- IPC_MESSAGE_HANDLER(DevToolsHostMsg_IndexPath, OnIndexPath)
- IPC_MESSAGE_HANDLER(DevToolsHostMsg_StopIndexing, OnStopIndexing)
- IPC_MESSAGE_HANDLER(DevToolsHostMsg_SearchInPath, OnSearchInPath)
+ IPC_MESSAGE_HANDLER(DevToolsHostMsg_DispatchOnEmbedder,
+ OnDispatchOnEmbedder)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
@@ -101,72 +86,11 @@ void DevToolsFrontendHost::RenderProcessGone(
void DevToolsFrontendHost::OnDispatchOnInspectorBackend(
const std::string& message) {
DevToolsManagerImpl::GetInstance()->DispatchOnInspectorBackend(this, message);
-// delegate_->DispatchOnInspectorBackend(message);
}
-void DevToolsFrontendHost::OnActivateWindow() {
- delegate_->ActivateWindow();
-}
-
-void DevToolsFrontendHost::OnChangeAttachedWindowHeight(unsigned height) {
- delegate_->ChangeAttachedWindowHeight(height);
-}
-
-void DevToolsFrontendHost::OnCloseWindow() {
- delegate_->CloseWindow();
-}
-
-void DevToolsFrontendHost::OnMoveWindow(int x, int y) {
- delegate_->MoveWindow(x, y);
-}
-
-void DevToolsFrontendHost::OnOpenInNewTab(const std::string& url) {
- delegate_->OpenInNewTab(url);
-}
-
-void DevToolsFrontendHost::OnSave(
- const std::string& url,
- const std::string& content,
- bool save_as) {
- delegate_->SaveToFile(url, content, save_as);
-}
-
-void DevToolsFrontendHost::OnAppend(
- const std::string& url,
- const std::string& content) {
- delegate_->AppendToFile(url, content);
-}
-
-void DevToolsFrontendHost::OnRequestFileSystems() {
- delegate_->RequestFileSystems();
-}
-
-void DevToolsFrontendHost::OnAddFileSystem() {
- delegate_->AddFileSystem();
-}
-
-void DevToolsFrontendHost::OnRemoveFileSystem(
- const std::string& file_system_path) {
- delegate_->RemoveFileSystem(file_system_path);
-}
-
-void DevToolsFrontendHost::OnIndexPath(int request_id,
- const std::string& file_system_path) {
- delegate_->IndexPath(request_id, file_system_path);
-}
-
-void DevToolsFrontendHost::OnStopIndexing(int request_id) {
- delegate_->StopIndexing(request_id);
-}
-
-void DevToolsFrontendHost::OnSearchInPath(int request_id,
- const std::string& file_system_path,
- const std::string& query) {
- delegate_->SearchInPath(request_id, file_system_path, query);
-}
-
-void DevToolsFrontendHost::OnRequestSetDockSide(const std::string& side) {
- delegate_->SetDockSide(side);
+void DevToolsFrontendHost::OnDispatchOnEmbedder(
+ const std::string& message) {
+ delegate_->DispatchOnEmbedder(message);
}
} // namespace content
« no previous file with comments | « content/browser/devtools/devtools_frontend_host.h ('k') | content/common/devtools_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698