Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5219)

Unified Diff: chrome/browser/google_apis/drive_api_requests.cc

Issue 22909041: Refactor GetAboutRequest and GetApplistRequest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google_apis/drive_api_requests.cc
diff --git a/chrome/browser/google_apis/drive_api_requests.cc b/chrome/browser/google_apis/drive_api_requests.cc
index 7fb418c2be6b4828c4c77b131c50cfec0db53eb5..e338454ec7120c7fbfd12705e4376405c27f9207 100644
--- a/chrome/browser/google_apis/drive_api_requests.cc
+++ b/chrome/browser/google_apis/drive_api_requests.cc
@@ -69,41 +69,6 @@ void ParseFileResourceWithUploadRangeAndRun(
} // namespace
-//============================== GetAboutRequest =============================
-
-GetAboutRequest::GetAboutRequest(
- RequestSender* sender,
- const DriveApiUrlGenerator& url_generator,
- const GetAboutResourceCallback& callback)
- : GetDataRequest(sender,
- base::Bind(&ParseJsonAndRun<AboutResource>, callback)),
- url_generator_(url_generator) {
- DCHECK(!callback.is_null());
-}
-
-GetAboutRequest::~GetAboutRequest() {}
-
-GURL GetAboutRequest::GetURL() const {
- return url_generator_.GetAboutUrl();
-}
-
-//============================== GetApplistRequest ===========================
-
-GetApplistRequest::GetApplistRequest(
- RequestSender* sender,
- const DriveApiUrlGenerator& url_generator,
- const GetDataCallback& callback)
- : GetDataRequest(sender, callback),
- url_generator_(url_generator) {
- DCHECK(!callback.is_null());
-}
-
-GetApplistRequest::~GetApplistRequest() {}
-
-GURL GetApplistRequest::GetURL() const {
- return url_generator_.GetApplistUrl();
-}
-
//============================ GetChangelistRequest ==========================
GetChangelistRequest::GetChangelistRequest(
@@ -171,6 +136,42 @@ GURL GetFileRequest::GetURL() const {
namespace drive {
+//============================== AboutGetRequest =============================
+
+AboutGetRequest::AboutGetRequest(
+ RequestSender* sender,
+ const DriveApiUrlGenerator& url_generator,
+ const AboutResourceCallback& callback)
+ : GetDataRequest(sender,
+ base::Bind(&ParseJsonAndRun<AboutResource>, callback)),
+ url_generator_(url_generator) {
+ DCHECK(!callback.is_null());
+}
+
+AboutGetRequest::~AboutGetRequest() {}
+
+GURL AboutGetRequest::GetURL() const {
+ return url_generator_.GetAboutGetUrl();
+}
+
+//============================== AppsListRequest ===========================
+
+AppsListRequest::AppsListRequest(
+ RequestSender* sender,
+ const DriveApiUrlGenerator& url_generator,
+ const AppListCallback& callback)
+ : GetDataRequest(sender,
+ base::Bind(&ParseJsonAndRun<AppList>, callback)),
+ url_generator_(url_generator) {
+ DCHECK(!callback.is_null());
+}
+
+AppsListRequest::~AppsListRequest() {}
+
+GURL AppsListRequest::GetURL() const {
+ return url_generator_.GetAppsListUrl();
+}
+
//======================= ContinueGetFileListRequest =========================
ContinueGetFileListRequest::ContinueGetFileListRequest(
« no previous file with comments | « chrome/browser/google_apis/drive_api_requests.h ('k') | chrome/browser/google_apis/drive_api_requests_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698