Issue 22909041: Refactor GetAboutRequest and GetApplistRequest.

Issue 22909041: Refactor GetAboutRequest and GetApplistRequest. (Closed)

Created:
7 years, 4 months ago by hidehiko

Modified:
7 years, 4 months ago

Reviewers:
kinaba

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactor GetAboutRequest and GetApplistRequest. Renamed to AboutGetRequest and AppsListRequest to reflect the Drive API v2's method name. Renamed Callbacks to AboutResourceCallback and AppListCallback. Moved requests classes to google_apis::drive namespace. Move AppList's parsing code from DriveAPIService to AppsListRequest. BUG=275233, 277253 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219310

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -181 lines)			Patch
M	chrome/browser/chromeos/drive/job_scheduler.h	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/drive/job_scheduler.cc	View	4 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/drive/drive_api_service.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/drive/drive_api_service.cc	View	5 chunks	+9 lines, -39 lines	0 comments	Download
M	chrome/browser/drive/drive_service_interface.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/drive/dummy_drive_service.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/drive/dummy_drive_service.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/drive/fake_drive_service.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/drive/fake_drive_service.cc	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/drive/gdata_wapi_service.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/drive/gdata_wapi_service.cc	View	6 chunks	+8 lines, -9 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests.h	View	2 chunks	+44 lines, -41 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests.cc	View	2 chunks	+36 lines, -35 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests_unittest.cc	View	6 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_url_generator.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_url_generator.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_url_generator_unittest.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/google_apis/drive_common_callbacks.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download