Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: chrome/browser/google_apis/drive_api_requests.cc

Issue 22909041: Refactor GetAboutRequest and GetApplistRequest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/google_apis/drive_api_requests.h" 5 #include "chrome/browser/google_apis/drive_api_requests.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/json/json_writer.h" 9 #include "base/json/json_writer.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 scoped_ptr<FileResource>()); 62 scoped_ptr<FileResource>());
63 return; 63 return;
64 } 64 }
65 } 65 }
66 66
67 callback.Run(response, file_resource.Pass()); 67 callback.Run(response, file_resource.Pass());
68 } 68 }
69 69
70 } // namespace 70 } // namespace
71 71
72 //============================== GetAboutRequest =============================
73
74 GetAboutRequest::GetAboutRequest(
75 RequestSender* sender,
76 const DriveApiUrlGenerator& url_generator,
77 const GetAboutResourceCallback& callback)
78 : GetDataRequest(sender,
79 base::Bind(&ParseJsonAndRun<AboutResource>, callback)),
80 url_generator_(url_generator) {
81 DCHECK(!callback.is_null());
82 }
83
84 GetAboutRequest::~GetAboutRequest() {}
85
86 GURL GetAboutRequest::GetURL() const {
87 return url_generator_.GetAboutUrl();
88 }
89
90 //============================== GetApplistRequest ===========================
91
92 GetApplistRequest::GetApplistRequest(
93 RequestSender* sender,
94 const DriveApiUrlGenerator& url_generator,
95 const GetDataCallback& callback)
96 : GetDataRequest(sender, callback),
97 url_generator_(url_generator) {
98 DCHECK(!callback.is_null());
99 }
100
101 GetApplistRequest::~GetApplistRequest() {}
102
103 GURL GetApplistRequest::GetURL() const {
104 return url_generator_.GetApplistUrl();
105 }
106
107 //============================ GetChangelistRequest ========================== 72 //============================ GetChangelistRequest ==========================
108 73
109 GetChangelistRequest::GetChangelistRequest( 74 GetChangelistRequest::GetChangelistRequest(
110 RequestSender* sender, 75 RequestSender* sender,
111 const DriveApiUrlGenerator& url_generator, 76 const DriveApiUrlGenerator& url_generator,
112 bool include_deleted, 77 bool include_deleted,
113 int64 start_changestamp, 78 int64 start_changestamp,
114 int max_results, 79 int max_results,
115 const GetDataCallback& callback) 80 const GetDataCallback& callback)
116 : GetDataRequest(sender, callback), 81 : GetDataRequest(sender, callback),
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 } 129 }
165 130
166 GetFileRequest::~GetFileRequest() {} 131 GetFileRequest::~GetFileRequest() {}
167 132
168 GURL GetFileRequest::GetURL() const { 133 GURL GetFileRequest::GetURL() const {
169 return url_generator_.GetFileUrl(file_id_); 134 return url_generator_.GetFileUrl(file_id_);
170 } 135 }
171 136
172 namespace drive { 137 namespace drive {
173 138
139 //============================== AboutGetRequest =============================
140
141 AboutGetRequest::AboutGetRequest(
142 RequestSender* sender,
143 const DriveApiUrlGenerator& url_generator,
144 const AboutResourceCallback& callback)
145 : GetDataRequest(sender,
146 base::Bind(&ParseJsonAndRun<AboutResource>, callback)),
147 url_generator_(url_generator) {
148 DCHECK(!callback.is_null());
149 }
150
151 AboutGetRequest::~AboutGetRequest() {}
152
153 GURL AboutGetRequest::GetURL() const {
154 return url_generator_.GetAboutGetUrl();
155 }
156
157 //============================== AppsListRequest ===========================
158
159 AppsListRequest::AppsListRequest(
160 RequestSender* sender,
161 const DriveApiUrlGenerator& url_generator,
162 const AppListCallback& callback)
163 : GetDataRequest(sender,
164 base::Bind(&ParseJsonAndRun<AppList>, callback)),
165 url_generator_(url_generator) {
166 DCHECK(!callback.is_null());
167 }
168
169 AppsListRequest::~AppsListRequest() {}
170
171 GURL AppsListRequest::GetURL() const {
172 return url_generator_.GetAppsListUrl();
173 }
174
174 //======================= ContinueGetFileListRequest ========================= 175 //======================= ContinueGetFileListRequest =========================
175 176
176 ContinueGetFileListRequest::ContinueGetFileListRequest( 177 ContinueGetFileListRequest::ContinueGetFileListRequest(
177 RequestSender* sender, 178 RequestSender* sender,
178 const GURL& url, 179 const GURL& url,
179 const GetDataCallback& callback) 180 const GetDataCallback& callback)
180 : GetDataRequest(sender, callback), 181 : GetDataRequest(sender, callback),
181 url_(url) { 182 url_(url) {
182 DCHECK(!callback.is_null()); 183 DCHECK(!callback.is_null());
183 } 184 }
(...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after
661 progress_callback, 662 progress_callback,
662 url_generator.GenerateDownloadFileUrl(resource_id), 663 url_generator.GenerateDownloadFileUrl(resource_id),
663 output_file_path) { 664 output_file_path) {
664 } 665 }
665 666
666 DownloadFileRequest::~DownloadFileRequest() { 667 DownloadFileRequest::~DownloadFileRequest() {
667 } 668 }
668 669
669 } // namespace drive 670 } // namespace drive
670 } // namespace google_apis 671 } // namespace google_apis
OLDNEW
« no previous file with comments | « chrome/browser/google_apis/drive_api_requests.h ('k') | chrome/browser/google_apis/drive_api_requests_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698