Move Floats out of RenderBlock

Move Floats out of RenderBlock

This not only makes the code more readable and maintainable, it also
will allow for more decoupling of RenderBlock and the FloatingObjects,
hopefully making it possible for FloatingObjects to be more central and
not need to have one for each RenderBlock that is affected by floats.

BUG=271774
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156231

[Bem Jones-Bey (adobe), 2013-08-15 17:59:27]

So I pulled it out. What do you think? I does compile, and it doesn't look like
I've broken any tests so far.

[ojan, 2013-08-15 18:18:49]

lgtm

[Bem Jones-Bey (adobe), 2013-08-15 18:31:27]

On 2013/08/15 17:59:27, Bem Jones-Bey (adobe) wrote:
> So I pulled it out. What do you think? I does compile, and it doesn't look
like
> I've broken any tests so far.

Apparently my local build lied to me, and it doesn't compile. Guess I should do
a clean and find more about what I missed.

[eseidel, 2013-08-15 19:37:42]

We have some unexplained perf regressions from earlier this week which could be
related to our float refactoring. :)

I'm happy for us to continue to split this out, but also to be wary that we may
have to do some perf cleanup if we regressed things.

[eseidel, 2013-08-15 19:38:05]

Thanks for doing this.

[eseidel, 2013-08-15 21:41:38]

lgtm

[commit-bot: I haz the power, 2013-08-15 21:41:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bjonesbe@adobe.com/22893013/9001

[commit-bot: I haz the power, 2013-08-15 22:14:06]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_blink_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Bem Jones-Bey (adobe), 2013-08-15 22:31:26]

On 2013/08/15 22:14:06, I haz the power (commit-bot) wrote:
> Sorry for I got bad news for ya.
> Compile failed with a clobber build on linux_blink_rel.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...
> Your code is likely broken or HEAD is junk. Please ensure your
> code is not broken then alert the build sheriffs.
> Look at the try server FAQ for more details.

Apparently today is not my day. Guess it's time for another clean build, since
this didn't break locally for me. :-(

[Bem Jones-Bey (adobe), 2013-08-16 16:33:01]

On 2013/08/15 22:31:26, Bem Jones-Bey (adobe) wrote:
> On 2013/08/15 22:14:06, I haz the power (commit-bot) wrote:
> > Sorry for I got bad news for ya.
> > Compile failed with a clobber build on linux_blink_rel.
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...
> > Your code is likely broken or HEAD is junk. Please ensure your
> > code is not broken then alert the build sheriffs.
> > Look at the try server FAQ for more details.
> 
> Apparently today is not my day. Guess it's time for another clean build, since
> this didn't break locally for me. :-(

Duh. Release builds are different than debug builds. Problem solved, passing off
again to the CQ, since I apparently can't be trusted.

[commit-bot: I haz the power, 2013-08-16 16:33:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bjonesbe@adobe.com/22893013/22001

[commit-bot: I haz the power, 2013-08-16 17:55:27]

Change committed as 156231