Stop throwing DOM exceptions in internal 'XMLHttpRequest' response getters.

Stop throwing DOM exceptions in internal 'XMLHttpRequest' response getters.

Unlike 'responseText' and 'responseXML', 'responseBlob' and
'responseArrayBuffer' are not exposed to JavaScript (they don't
appear in the IDL or in the specification). As they are only called from
custom bindings in response to a JavaScript call to the 'response' getter,
we can safely replace the exception-throwing code in the implementation
with an ASSERT that the request type is correct.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155954

[Mike West, 2013-08-12 13:55:15]

Hi Takeshi and Erik. Mind taking a quick look at this CL to (slightly) simplify
'XMLHttpRequest::responseBlob()'?

Thanks!

-mike

[Mike West, 2013-08-12 14:01:36]

On 2013/08/12 13:55:15, Mike West wrote:
> Hi Takeshi and Erik. Mind taking a quick look at this CL to (slightly)
simplify
> 'XMLHttpRequest::responseBlob()'?
> 
> Thanks!
> 
> -mike

responseArrayBuffer too.

[arv (Not doing code reviews), 2013-08-12 15:02:42]

Typos in CL description

they doesn't -> they don't
they is -> they are

[arv (Not doing code reviews), 2013-08-12 15:04:26]

LGTM

[Use mkwst_at_chromium.org plz., 2013-08-12 15:07:09]

On 2013/08/12 15:02:42, arv wrote:
> Typos in CL description
> 
> they doesn't -> they don't
> they is -> they are

Thanks for catching these... I did a pretty bad job pluralizing the initial text
after adding responseArrayBuffer. :)

[commit-bot: I haz the power, 2013-08-12 15:07:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/22842002/5001

[commit-bot: I haz the power, 2013-08-12 15:20:35]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[Mike West, 2013-08-12 18:56:10]

Hrm. Aren't you a bindings owner, Erik? Presubmit doesn't like you. :/

Jochen, rs=? for the bindings bits?

[arv (Not doing code reviews), 2013-08-12 19:13:10]

No one likes me :'(

jk, https://codereview.chromium.org/22901003


On Mon, Aug 12, 2013 at 2:56 PM, <mkwst@chromium.org> wrote:

> Hrm. Aren't you a bindings owner, Erik? Presubmit doesn't like you. :/
>
> Jochen, rs=? for the bindings bits?
>
>
https://codereview.chromium.**org/22842002/<https://codereview.chromium.org/2...
>



-- 
erik

[jochen (gone - plz use gerrit), 2013-08-12 19:24:47]

lgtm

[commit-bot: I haz the power, 2013-08-12 19:25:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/22842002/5001

[commit-bot: I haz the power, 2013-08-12 21:49:44]

Change committed as 155954

[tyoshino (SeeGerritForStatus), 2013-08-13 03:39:19]

lgtm thanks!