Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

Issue 22842002: Stop throwing DOM exceptions in internal 'XMLHttpRequest' response getters. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Moar. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/xml/XMLHttpRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp
diff --git a/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp b/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp
index e9eabc2f481e2d3c3260862ca2cb4c9148399f7b..9d734b6b26dae63a141ed17f7f7b534b61d3b2bd 100644
--- a/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp
+++ b/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp
@@ -102,20 +102,14 @@ void V8XMLHttpRequest::responseAttrGetterCustom(v8::Local<v8::String> name, cons
case XMLHttpRequest::ResponseTypeBlob:
{
- ExceptionState es(info.GetIsolate());
- Blob* blob = xmlHttpRequest->responseBlob(es);
- if (es.throwIfNeeded())
- return;
+ Blob* blob = xmlHttpRequest->responseBlob();
v8SetReturnValue(info, toV8Fast(blob, info, xmlHttpRequest));
return;
}
case XMLHttpRequest::ResponseTypeArrayBuffer:
{
- ExceptionState es(info.GetIsolate());
- ArrayBuffer* arrayBuffer = xmlHttpRequest->responseArrayBuffer(es);
- if (es.throwIfNeeded())
- return;
+ ArrayBuffer* arrayBuffer = xmlHttpRequest->responseArrayBuffer();
if (arrayBuffer && !arrayBuffer->hasDeallocationObserver()) {
arrayBuffer->setDeallocationObserver(V8ArrayBufferDeallocationObserver::instance());
v8::V8::AdjustAmountOfExternalAllocatedMemory(arrayBuffer->byteLength());
« no previous file with comments | « no previous file | Source/core/xml/XMLHttpRequest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698