Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2282783003: [Remoting Android] Create Interfaces for GlDisplay (Closed)

Created:
4 years, 3 months ago by Yuwei
Modified:
4 years, 3 months ago
Reviewers:
Hzj_jie, joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Create Interfaces for GlDisplay This CL adds RenderStub and RenderCallback interface for GlDisplay in preparation of moving render controlling logic out of DesktopView and removing GlDesktopView. BUG=641123 Committed: https://crrev.com/0c198c51b1a159bc0354106588ef54903e4d818c Cr-Commit-Position: refs/heads/master@{#416415}

Patch Set 1 : [Remoting Android] Create Interfaces for GlDisplay #

Total comments: 20

Patch Set 2 : Reviewer's Feedback #

Total comments: 11

Patch Set 3 : Fix comment: Initializes -> Resets #

Patch Set 4 : Merge ToT #

Patch Set 5 : Merge ToT again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -84 lines) Patch
M remoting/android/client_java_tmpl.gni View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/DesktopView.java View 1 2 3 4 2 chunks +1 line, -8 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java View 1 2 3 3 chunks +9 lines, -21 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/InputFeedbackRadiusMapper.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/InputStrategyInterface.java View 1 chunk +2 lines, -2 lines 0 comments Download
A remoting/android/java/src/org/chromium/chromoting/RenderStub.java View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/TouchInputStrategy.java View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/TrackpadInputStrategy.java View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java View 1 2 3 8 chunks +67 lines, -36 lines 0 comments Download

Messages

Total messages: 35 (9 generated)
Yuwei
ptal
4 years, 3 months ago (2016-08-26 21:06:26 UTC) #5
Yuwei
FYI this is my plan for refactoring DesktopView: https://docs.google.com/document/d/1mdJNI-CnpoJf6tSCeKphK6Bd4fyqtn3sjA_Nm5EXUnQ/edit?usp=sharing
4 years, 3 months ago (2016-08-27 01:10:00 UTC) #7
Yuwei
https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/RenderStub.java File remoting/android/java/src/org/chromium/chromoting/RenderStub.java (right): https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/RenderStub.java#newcode48 remoting/android/java/src/org/chromium/chromoting/RenderStub.java:48: final class InputFeedbackRadiusMapper { Not sure whether it is ...
4 years, 3 months ago (2016-08-29 22:09:42 UTC) #8
joedow
https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/RenderCallback.java File remoting/android/java/src/org/chromium/chromoting/RenderCallback.java (right): https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/RenderCallback.java#newcode10 remoting/android/java/src/org/chromium/chromoting/RenderCallback.java:10: public interface RenderCallback { Why separate this out from ...
4 years, 3 months ago (2016-08-29 22:35:41 UTC) #9
Hzj_jie
https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java File remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java (right): https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java#newcode39 remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java:39: getHolder().addCallback(this); It looks like you are still using GlDesktopView ...
4 years, 3 months ago (2016-08-29 22:52:51 UTC) #10
Yuwei
https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java File remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java (right): https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java#newcode39 remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java:39: getHolder().addCallback(this); On 2016/08/29 22:52:51, Hzj_jie wrote: > It looks ...
4 years, 3 months ago (2016-08-29 23:38:21 UTC) #11
Yuwei
https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/RenderStub.java File remoting/android/java/src/org/chromium/chromoting/RenderStub.java (right): https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/RenderStub.java#newcode48 remoting/android/java/src/org/chromium/chromoting/RenderStub.java:48: final class InputFeedbackRadiusMapper { On 2016/08/29 22:52:51, Hzj_jie wrote: ...
4 years, 3 months ago (2016-08-30 22:08:00 UTC) #12
Yuwei
PTAL https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/RenderCallback.java File remoting/android/java/src/org/chromium/chromoting/RenderCallback.java (right): https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/RenderCallback.java#newcode10 remoting/android/java/src/org/chromium/chromoting/RenderCallback.java:10: public interface RenderCallback { On 2016/08/29 22:35:41, joedow ...
4 years, 3 months ago (2016-08-30 22:39:12 UTC) #13
joedow
https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/RenderStub.java File remoting/android/java/src/org/chromium/chromoting/RenderStub.java (right): https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/RenderStub.java#newcode48 remoting/android/java/src/org/chromium/chromoting/RenderStub.java:48: final class InputFeedbackRadiusMapper { On 2016/08/30 22:08:00, Yuwei wrote: ...
4 years, 3 months ago (2016-08-30 23:08:33 UTC) #14
Hzj_jie
https://codereview.chromium.org/2282783003/diff/40001/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java File remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java (right): https://codereview.chromium.org/2282783003/diff/40001/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java#newcode44 remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java:44: mDisplay.showInputFeedback(feedbackToShow, pos); I believe you will remove this and ...
4 years, 3 months ago (2016-08-30 23:15:03 UTC) #15
Yuwei
https://codereview.chromium.org/2282783003/diff/40001/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java File remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java (right): https://codereview.chromium.org/2282783003/diff/40001/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java#newcode44 remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java:44: mDisplay.showInputFeedback(feedbackToShow, pos); On 2016/08/30 23:15:03, Hzj_jie wrote: > I ...
4 years, 3 months ago (2016-08-31 00:15:56 UTC) #16
Yuwei
On 2016/08/30 23:08:33, joedow wrote: > https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/RenderStub.java > File remoting/android/java/src/org/chromium/chromoting/RenderStub.java (right): > > https://codereview.chromium.org/2282783003/diff/20001/remoting/android/java/src/org/chromium/chromoting/RenderStub.java#newcode48 > ...
4 years, 3 months ago (2016-08-31 00:25:46 UTC) #17
Hzj_jie
https://codereview.chromium.org/2282783003/diff/40001/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java File remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java (right): https://codereview.chromium.org/2282783003/diff/40001/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java#newcode44 remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java:44: mDisplay.showInputFeedback(feedbackToShow, pos); On 2016/08/31 00:15:56, Yuwei wrote: > On ...
4 years, 3 months ago (2016-08-31 00:31:57 UTC) #18
Yuwei
https://codereview.chromium.org/2282783003/diff/40001/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java File remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java (right): https://codereview.chromium.org/2282783003/diff/40001/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java#newcode44 remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java:44: mDisplay.showInputFeedback(feedbackToShow, pos); On 2016/08/31 00:31:57, Hzj_jie wrote: > On ...
4 years, 3 months ago (2016-08-31 00:47:40 UTC) #19
Hzj_jie
LGTM https://codereview.chromium.org/2282783003/diff/40001/remoting/android/java/src/org/chromium/chromoting/RenderStub.java File remoting/android/java/src/org/chromium/chromoting/RenderStub.java (right): https://codereview.chromium.org/2282783003/diff/40001/remoting/android/java/src/org/chromium/chromoting/RenderStub.java#newcode48 remoting/android/java/src/org/chromium/chromoting/RenderStub.java:48: Event<SizeChangedEventParameter> onClientSizeChanged(); On 2016/08/31 00:47:40, Yuwei wrote: > ...
4 years, 3 months ago (2016-08-31 00:59:21 UTC) #20
Yuwei
On 2016/08/31 00:59:21, Hzj_jie wrote: > LGTM > > https://codereview.chromium.org/2282783003/diff/40001/remoting/android/java/src/org/chromium/chromoting/RenderStub.java > File remoting/android/java/src/org/chromium/chromoting/RenderStub.java (right): > ...
4 years, 3 months ago (2016-08-31 01:06:06 UTC) #21
Yuwei
I've discussed the refactoring plan with zijiehe@. He is planning to replace TouchInputHandler with a ...
4 years, 3 months ago (2016-09-01 01:04:03 UTC) #22
Hzj_jie
On 2016/09/01 01:04:03, Yuwei wrote: > I've discussed the refactoring plan with zijiehe@. > > ...
4 years, 3 months ago (2016-09-01 01:25:09 UTC) #23
Yuwei
On 2016/09/01 01:25:09, Hzj_jie wrote: > On 2016/09/01 01:04:03, Yuwei wrote: > > I've discussed ...
4 years, 3 months ago (2016-09-01 02:05:04 UTC) #24
Yuwei
On 2016/09/01 02:05:04, Yuwei wrote: > On 2016/09/01 01:25:09, Hzj_jie wrote: > > On 2016/09/01 ...
4 years, 3 months ago (2016-09-02 18:00:03 UTC) #25
Hzj_jie
On 2016/09/02 18:00:03, Yuwei wrote: > On 2016/09/01 02:05:04, Yuwei wrote: > > On 2016/09/01 ...
4 years, 3 months ago (2016-09-02 18:24:03 UTC) #26
Yuwei
@joedow Ping O_o?
4 years, 3 months ago (2016-09-02 23:09:49 UTC) #27
joedow
lgtm
4 years, 3 months ago (2016-09-02 23:15:17 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282783003/100001
4 years, 3 months ago (2016-09-02 23:17:47 UTC) #31
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 3 months ago (2016-09-03 00:43:44 UTC) #33
commit-bot: I haz the power
4 years, 3 months ago (2016-09-03 00:46:50 UTC) #35
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0c198c51b1a159bc0354106588ef54903e4d818c
Cr-Commit-Position: refs/heads/master@{#416415}

Powered by Google App Engine
This is Rietveld 408576698