src/api.cc - Issue 22795004: abstract eternal into class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 22795004: abstract eternal into class (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index eb2ffcff18094e3e3b2fe37c4a1dbe7276ea9e97..d40bb233874e034d29751c98be0052fbdfdacd83 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -676,8 +676,8 @@ void V8::DisposeGlobal(i::Object** obj) {

}

-int V8::Eternalize(i::Isolate* isolate, i::Object** handle) {

- return isolate->eternal_handles()->Create(isolate, *handle);

+void V8::Eternalize(i::Isolate* isolate, i::Object** handle, int* index) {

rossberg 2013/08/12 15:13:13 Is there a reason for changing this? I'd keep the

dcarney 2013/08/13 06:46:24 The assertion that you're not reinitializing an et

+ isolate->eternal_handles()->Create(isolate, *handle, index);

}