Chromium Code Reviews| Index: src/global-handles.h |
| diff --git a/src/global-handles.h b/src/global-handles.h |
| index 2c20711ea179594abffd515f4abc6a19e3b5dcb8..fe1375af00a8d353a9610c6e62b19e8b96953033 100644 |
| --- a/src/global-handles.h |
| +++ b/src/global-handles.h |
| @@ -396,8 +396,8 @@ class EternalHandles { |
| int NumberOfHandles() { return size_; } |
| - // Create an EternalHandle, returning the index. |
| - int Create(Isolate* isolate, Object* object); |
| + // Create an EternalHandle, overwriting the index. |
| + void Create(Isolate* isolate, Object* object, int* index); |
|
rossberg
2013/08/12 15:13:13
Same here.
|
| // Grab the handle for an existing EternalHandle. |
| inline Handle<Object> Get(int index) { |
| @@ -419,8 +419,7 @@ class EternalHandles { |
| Handle<Object> CreateSingleton(Isolate* isolate, |
| Object* object, |
| SingletonHandle singleton) { |
| - ASSERT(singleton_handles_[singleton] == kInvalidIndex); |
| - singleton_handles_[singleton] = Create(isolate, object); |
| + Create(isolate, object, &singleton_handles_[singleton]); |
| return Get(singleton_handles_[singleton]); |
| } |