abstract eternal into class

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 658 matching lines @@
 void V8::ClearWeak(i::Object** obj) {
   i::GlobalHandles::ClearWeakness(obj);
 }
 
 
 void V8::DisposeGlobal(i::Object** obj) {
   i::GlobalHandles::Destroy(obj);
 }
 
 
-int V8::Eternalize(i::Isolate* isolate, i::Object** handle) {
-  return isolate->eternal_handles()->Create(isolate, *handle);
+void V8::Eternalize(i::Isolate* isolate, i::Object** handle, int* index) {

[rossberg, 2013/08/12 15:13:13]

Is there a reason for changing this? I'd keep the functional version if
possible.

[dcarney, 2013/08/13 06:46:24]

The assertion that you're not reinitializing an eternal is in Create().

+  isolate->eternal_handles()->Create(isolate, *handle, index);
 }
 
 
 i::Object** V8::GetEternal(i::Isolate* isolate, int index) {
   return isolate->eternal_handles()->Get(index).location();
 }
 
 
 // --- H a n d l e s ---
 
@@ skipping 7482 matching lines @@
   Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate());
   Address callback_address =
       reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
   VMState<EXTERNAL> state(isolate);
   ExternalCallbackScope call_scope(isolate, callback_address);
   return callback(info);
 }
 
 
 } }  // namespace v8::internal