Issue 22667003: Reland "216874 - Use overview mode for alt-tab cycling."

Issue 22667003: Reland "216874 - Use overview mode for alt-tab cycling." (Closed)

Created:
7 years, 4 months ago by flackr

Modified:
7 years, 4 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reland "216874 - Use overview mode for alt-tab cycling." Fixes valgrind failure and relands overview mode using alt-tab. BUG=263481, 264289 TEST=WindowSelectorTest.Basic,WindowSelectorTest.BasicCycle TEST=Enable --ash-enable-overview-mode and use alt-tab to cycle through MRU windows. Cycling is done in overview mode on active display. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216916

Patch Set 1 #

Patch Set 2 : Fix use after free in event handling. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+616 lines, -107 lines)			Patch
M	ash/accelerators/accelerator_controller.cc	View		2 chunks	+14 lines, -0 lines	0 comments	Download
M	ash/wm/window_selector.h	View		3 chunks	+62 lines, -21 lines	0 comments	Download
M	ash/wm/window_selector.cc	View	1	4 chunks	+413 lines, -83 lines	0 comments	Download
M	ash/wm/window_selector_controller.h	View		4 chunks	+15 lines, -0 lines	0 comments	Download
M	ash/wm/window_selector_controller.cc	View		2 chunks	+62 lines, -1 line	0 comments	Download
M	ash/wm/window_selector_unittest.cc	View		4 chunks	+50 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

flackr

Hi, Patchset 1 is the original patch that you reviewed in https://codereview.chromium.org/22715005/. There was a ...

7 years, 4 months ago (2013-08-11 04:23:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/22667003/3001

7 years, 4 months ago (2013-08-11 14:26:39 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 4 months ago (2013-08-11 14:34:24 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/22667003/3001

7 years, 4 months ago (2013-08-11 17:33:04 UTC) #5

Message was sent while issue was closed.

Change committed as 216916

Expand Messages | Collapse Messages