Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: content/browser/webui/url_data_manager_backend_unittest.cc

Issue 2262653003: Make URLRequest::Read to return net errors or bytes read instead of a bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/layered_network_delegate.h » ('j') | net/base/layered_network_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/webui/url_data_manager_backend_unittest.cc
diff --git a/content/browser/webui/url_data_manager_backend_unittest.cc b/content/browser/webui/url_data_manager_backend_unittest.cc
index fdf50037d742ea0f07625a2b00e1903f4ac83b9a..3c995c632369d581d49673d3b5a48df33abea2e1 100644
--- a/content/browser/webui/url_data_manager_backend_unittest.cc
+++ b/content/browser/webui/url_data_manager_backend_unittest.cc
@@ -26,15 +26,15 @@ class CancelAfterFirstReadURLRequestDelegate : public net::TestDelegate {
~CancelAfterFirstReadURLRequestDelegate() override {}
- void OnResponseStarted(net::URLRequest* request) override {
+ void OnResponseStarted(net::URLRequest* request, int net_error) override {
// net::TestDelegate will start the first read.
- TestDelegate::OnResponseStarted(request);
+ TestDelegate::OnResponseStarted(request, net_error);
request->Cancel();
}
void OnReadCompleted(net::URLRequest* request, int bytes_read) override {
// Read should have been cancelled.
- EXPECT_EQ(-1, bytes_read);
+ EXPECT_EQ(net::ERR_ABORTED, bytes_read);
}
private:
« no previous file with comments | « no previous file | net/base/layered_network_delegate.h » ('j') | net/base/layered_network_delegate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698