Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Unified Diff: net/base/layered_network_delegate.cc

Issue 2262653003: Make URLRequest::Read to return net errors or bytes read instead of a bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/layered_network_delegate.cc
diff --git a/net/base/layered_network_delegate.cc b/net/base/layered_network_delegate.cc
index 24e3e246f489831abba29afbc2117790a98af1d5..914e62fdf893399765ae0b92bb941ed481c78fcb 100644
--- a/net/base/layered_network_delegate.cc
+++ b/net/base/layered_network_delegate.cc
@@ -104,9 +104,10 @@ void LayeredNetworkDelegate::OnBeforeRedirectInternal(
const GURL& new_location) {
}
-void LayeredNetworkDelegate::OnResponseStarted(URLRequest* request) {
+void LayeredNetworkDelegate::OnResponseStarted(URLRequest* request,
+ int net_error) {
OnResponseStartedInternal(request);
- nested_network_delegate_->NotifyResponseStarted(request);
+ nested_network_delegate_->NotifyResponseStarted(request, net_error);
}
void LayeredNetworkDelegate::OnResponseStartedInternal(URLRequest* request) {
@@ -131,14 +132,15 @@ void LayeredNetworkDelegate::OnNetworkBytesSent(URLRequest* request,
void LayeredNetworkDelegate::OnNetworkBytesSentInternal(URLRequest* request,
int64_t bytes_sent) {}
-void LayeredNetworkDelegate::OnCompleted(URLRequest* request, bool started) {
+void LayeredNetworkDelegate::OnCompleted(URLRequest* request,
+ bool started,
+ int net_error) {
OnCompletedInternal(request, started);
- nested_network_delegate_->NotifyCompleted(request, started);
+ nested_network_delegate_->NotifyCompleted(request, started, net_error);
}
void LayeredNetworkDelegate::OnCompletedInternal(URLRequest* request,
- bool started) {
-}
+ bool started) {}
void LayeredNetworkDelegate::OnURLRequestDestroyed(URLRequest* request) {
OnURLRequestDestroyedInternal(request);

Powered by Google App Engine
This is Rietveld 408576698