Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 22576002: Paint region based columns correctly in non-default writing-modes. (Closed)

Created:
7 years, 4 months ago by mstensho (USE GERRIT)
Modified:
7 years, 2 months ago
Reviewers:
eseidel
CC:
blink-reviews, dglazkov+blink, eae, leviw_travelin_and_unemployed, Julien - ping for review
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Paint region based columns correctly in non-default writing-modes. The column translation offset was calculated incorrectly. The dirty rect intersection check was also wrong. Added some documentation, to make it clear what's going on. This patch is ported from WebKit. https://bugs.webkit.org/show_bug.cgi?id=118506 Reviewed in WebKit by David Hyatt. BUG=269417 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158433

Patch Set 1 #

Patch Set 2 : Rebase master #

Patch Set 3 : Simplify comment, address code review minor issue raised with lgtm. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -8 lines) Patch
A LayoutTests/fast/multicol/newmulticol/hide-box-horizontal-bt.html View 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/newmulticol/hide-box-horizontal-bt-expected.html View 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/newmulticol/hide-box-vertical-lr.html View 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/newmulticol/hide-box-vertical-lr-expected.html View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/newmulticol/hide-box-vertical-rl.html View 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/newmulticol/hide-box-vertical-rl-expected.html View 1 chunk +21 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.cpp View 1 2 3 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mstensho (USE GERRIT)
7 years, 4 months ago (2013-08-07 11:47:28 UTC) #1
mstensho (USE GERRIT)
Please take a look.
7 years, 2 months ago (2013-09-26 08:10:28 UTC) #2
eseidel
lgtm The comment seems very confused and wishy-washy. Perhaps we can make it shorter and ...
7 years, 2 months ago (2013-09-26 16:31:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/22576002/8001
7 years, 2 months ago (2013-09-27 09:42:21 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-09-27 10:38:50 UTC) #5
Message was sent while issue was closed.
Change committed as 158433

Powered by Google App Engine
This is Rietveld 408576698