LayoutTests/fast/multicol/newmulticol/hide-box-vertical-rl.html - Issue 22576002: Paint region based columns correctly in non-default writing-modes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/hide-box-vertical-rl.html

Issue 22576002: Paint region based columns correctly in non-default writing-modes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Simplify comment, address code review minor issue raised with lgtm. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/hide-box-vertical-lr-expected.html ('k') | LayoutTests/fast/multicol/newmulticol/hide-box-vertical-rl-expected.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>hiding a box covering a multicol, vertical-rl</title>

	5 <script>

	6 if (window.testRunner)

	7 testRunner.waitUntilDone();

	8 if (window.internals)

	9 internals.settings.setRegionBasedColumnsEnabled(true);

	10 function scheduleHide() {

	11 document.body.offsetLeft;

	12 setTimeout("hideIt()", 100);

	13 }

	14 function hideIt() {

	15 document.getElementById('hider').style.visibility = 'hidden';

	16 document.body.offsetLeft;

	17 if (window.testRunner)

	18 testRunner.notifyDone();

	19 }

	20 </script>

	21 </head>

	22 <body onload="scheduleHide()" style="color:black; background:white;">

	23 <p>The word PASS should be seen below.</p>

	24 <div style="position:relative; width:30em; background:black;">

	25 <div id="hider" style="position:absolute; z-index:1; top:5.1em; righ t:12em; width:3em; height:3em; background:red;"></div>

	26 <div style="width:20em; height:20em; -webkit-writing-mode:vertical-r l;">

	27 <div style="-webkit-columns:4; -webkit-column-fill:auto; -webkit -column-gap:0; columns:4; column-fill:auto; column-gap:0; orphans:1; widows:1; - webkit-logical-height:6em; line-height:2em; background:cyan;">

	28 <br>

	29 <br>

	30 <br>

	31 <br>

	32 <div style="position:relative;"> PASS</div>

	33 </div>

	34 </div>

	35 </div>

	36 </body>

	37 </html>

OLD	NEW