WebSocket must not be established when subprotocol is not selected by the server

WebSocket must not be established when subprotocol is not selected by the server

Don't establish WebSocket connection if response's Sec-WebSocket-Protocol
header doesn't exist but client's subprotocol request exists.

BUG=259666
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155603

[yhirano, 2013-08-06 07:58:38]

lgtm

[+tyoshino]

[tyoshino (SeeGerritForStatus), 2013-08-06 08:13:14]

LGTM

+ricea for English

[tyoshino (SeeGerritForStatus), 2013-08-06 08:13:21]

https://codereview.chromium.org/22375002/diff/1/LayoutTests/http/tests/websoc...
File
LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection.html
(right):

https://codereview.chromium.org/22375002/diff/1/LayoutTests/http/tests/websoc...
LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection.html:10:
description("Test whether WebSocket handshake fails if the server doesn't send
Sec-WebSocket-Protocol header regardless of client's subprotocol request.");
I think
"regardless..."
should be like
"though the client sent subprotocol"

Adam-san?

[Adam Rice, 2013-08-06 08:42:16]

https://codereview.chromium.org/22375002/diff/1/LayoutTests/http/tests/websoc...
File
LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection.html
(right):

https://codereview.chromium.org/22375002/diff/1/LayoutTests/http/tests/websoc...
LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection.html:10:
description("Test whether WebSocket handshake fails if the server doesn't send
Sec-WebSocket-Protocol header regardless of client's subprotocol request.");
On 2013/08/06 08:13:21, tyoshino wrote:
> I think
> "regardless..."
> should be like
> "though the client sent subprotocol"
> 
> Adam-san?

I think that it would be clearer to write it the other way around, ie. "Verify
that the WebSocket handshake fails when the client requests a subprotocol but
the server doesn't include a Sec-WebSocket-Protocol header in the response."

[yusukesuzuki0, 2013-08-06 08:54:43]

https://codereview.chromium.org/22375002/diff/1/LayoutTests/http/tests/websoc...
File
LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection.html
(right):

https://codereview.chromium.org/22375002/diff/1/LayoutTests/http/tests/websoc...
LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection.html:10:
description("Test whether WebSocket handshake fails if the server doesn't send
Sec-WebSocket-Protocol header regardless of client's subprotocol request.");
On 2013/08/06 08:42:16, Adam Rice wrote:
> On 2013/08/06 08:13:21, tyoshino wrote:
> > I think
> > "regardless..."
> > should be like
> > "though the client sent subprotocol"
> > 
> > Adam-san?
> 
> I think that it would be clearer to write it the other way around, ie. "Verify
> that the WebSocket handshake fails when the client requests a subprotocol but
> the server doesn't include a Sec-WebSocket-Protocol header in the response."

I've changed test description.

[Adam Rice, 2013-08-06 09:04:16]

lgtm

[commit-bot: I haz the power, 2013-08-06 09:06:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukesuzuki@google.com/22375002/9001

[commit-bot: I haz the power, 2013-08-06 10:38:48]

Change committed as 155603