LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection.html - Issue 22375002: WebSocket must not be established when subprotocol is not selected by the server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection.html

Issue 22375002: WebSocket must not be established when subprotocol is not selected by the server (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix test description Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection.html

diff --git a/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header.html b/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection.html

similarity index 68%

copy from LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header.html

copy to LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection.html

index 048ad1e898330b4084583fdd045599ae33424bdf..eb6e59ecd4b808ee6dca98313fb90227300f2b80 100644

--- a/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header.html

+++ b/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection.html

@@ -7,12 +7,12 @@

-description("Test whether WebSocket handshake fails if the server sends incorrect Sec-WebSocket-Accept header.");

+description("Test for verifying that the WebSocket handshake fails when the client requests a subprotocol but the server doesn't include a Sec-WebSocket-Protocol header in the response.");

window.jsTestIsAsync = true;

-var url = "ws://localhost:8880/websocket/tests/hybi/handshake-fail-by-wrong-accept-header";

-var ws = new WebSocket(url);

+var url = "ws://localhost:8880/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection";

+var ws = new WebSocket(url, 'test');

var closeEvent;

ws.onopen = function()