AutocompleteInput::PageClassification -> AutocompleteInput::OmniboxContext.

AutocompleteInput::PageClassification -> AutocompleteInput::OmniboxContext.

Rename PageClassification to OmniboxContext since we are now tracking the
context more generally beyond what page the user is currently seeing.

BUG=264069

[samarth, 2013-08-06 17:39:21]

Hi Mark, Peter,

I decided to split off Mark's suggestion for renaming the enum into a separate
CL so you can see if you like it better.

If we also want to change the proto enum/field name, then we'll have to be
careful not to break any old analysis code or scripts. If we don't change that,
then I'm not sure if having two different names for the same thing is worth it.

Thanks,
Samarth

[Peter Kasting, 2013-08-06 19:09:34]

https://codereview.chromium.org/22364007/diff/1/chrome/browser/autocomplete/a...
File chrome/browser/autocomplete/autocomplete_input.h (right):

https://codereview.chromium.org/22364007/diff/1/chrome/browser/autocomplete/a...
chrome/browser/autocomplete/autocomplete_input.h:51: enum OmniboxContext {
"Omnibox" in this name seems unnecessary if we're already inside
AutocompleteInput.  Should this just be "Context"?  Or "ExternalContext" meaning
the context outside the omnibox itself?

[Mark P, 2013-08-08 13:43:47]

I'll leave it to you and Peter to negotiate the enum name.  I don't care that
much.

You can change the enum name in the protocol buffer too.  As long as you don't
change the protocol buffer field number there shouldn't be a problem. 
Obviously,
if you do that, we should make the corresponding internal google change too.

--mark

[Peter Kasting, 2013-10-08 00:12:15]

Samarth, do you still want to make a change here?

[samarth, 2013-10-08 17:48:11]

On 2013/10/08 00:12:15, Peter Kasting wrote:
> Samarth, do you still want to make a change here?

Yah, I should wrap this up.  I'll try to get back to it this week.

[samarth, 2013-10-25 23:43:08]

On 2013/10/08 17:48:11, samarth wrote:
> On 2013/10/08 00:12:15, Peter Kasting wrote:
> > Samarth, do you still want to make a change here?
> 
> Yah, I should wrap this up.  I'll try to get back to it this week.

Ok two weeks later and no progress here yet.  I'm going to go ahead and close
this issue.  Mark: let met know if you feel strongly about the name and I can at
least file a bug to track it and eventually get to it.

Thanks,
Samarth

[Mark P, 2013-10-26 00:46:13]

On 2013/10/25 23:43:08, samarth wrote:
> On 2013/10/08 17:48:11, samarth wrote:
> > On 2013/10/08 00:12:15, Peter Kasting wrote:
> > > Samarth, do you still want to make a change here?
> > 
> > Yah, I should wrap this up.  I'll try to get back to it this week.
> 
> Ok two weeks later and no progress here yet.  I'm going to go ahead and close
> this issue.  Mark: let met know if you feel strongly about the name and I can
at
> least file a bug to track it and eventually get to it.
> 
> Thanks,
> Samarth

I don't care much about the name; it's fine with me if you want to abandon this
issue.  I thought it was Peter who cared more than the current name was somewhat
inappropriate?

--mark