Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1447)

Unified Diff: chrome/browser/metrics/metrics_log.cc

Issue 22364007: AutocompleteInput::PageClassification -> AutocompleteInput::OmniboxContext. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_log.cc
diff --git a/chrome/browser/metrics/metrics_log.cc b/chrome/browser/metrics/metrics_log.cc
index bb9d5500b14f2b22bb8cac5572b03c1e615201b2..341f911fd7433bb923a59e841db7412c3de844e4 100644
--- a/chrome/browser/metrics/metrics_log.cc
+++ b/chrome/browser/metrics/metrics_log.cc
@@ -142,8 +142,8 @@ OmniboxEventProto::Suggestion::ResultType AsOmniboxEventResultType(
}
OmniboxEventProto::PageClassification AsOmniboxEventPageClassification(
- AutocompleteInput::PageClassification page_classification) {
- switch (page_classification) {
+ AutocompleteInput::OmniboxContext omnibox_context) {
+ switch (omnibox_context) {
case AutocompleteInput::INVALID_SPEC:
return OmniboxEventProto::INVALID_SPEC;
case AutocompleteInput::NEW_TAB_PAGE:
@@ -855,7 +855,7 @@ void MetricsLog::RecordOmniboxOpenedURL(const OmniboxLog& log) {
omnibox_event->set_duration_since_last_default_match_update_ms(
log.elapsed_time_since_last_change_to_default_match.InMilliseconds());
omnibox_event->set_current_page_classification(
- AsOmniboxEventPageClassification(log.current_page_classification));
+ AsOmniboxEventPageClassification(log.omnibox_context));
omnibox_event->set_input_type(AsOmniboxEventInputType(log.input_type));
// The view code to hide the top result is currently only implemented on the

Powered by Google App Engine
This is Rietveld 408576698