Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1414)

Unified Diff: chrome/browser/omnibox/omnibox_field_trial.h

Issue 22364007: AutocompleteInput::PageClassification -> AutocompleteInput::OmniboxContext. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/omnibox/omnibox_field_trial.h
diff --git a/chrome/browser/omnibox/omnibox_field_trial.h b/chrome/browser/omnibox/omnibox_field_trial.h
index 1ad3b16f9dd7159d05a04318deb4ee2677f2975d..20350a75fc0bf34e0d1620a27ce7d26defae77be 100644
--- a/chrome/browser/omnibox/omnibox_field_trial.h
+++ b/chrome/browser/omnibox/omnibox_field_trial.h
@@ -107,16 +107,16 @@ class OmniboxFieldTrial {
// field trial.
// Returns true if the user is in the experiment group that, given the
- // provided |current_page_classification| context, scores search history
- // query suggestions less aggressively so that they don't inline.
+ // provided |omnibox_context|, scores search history query suggestions less
+ // aggressively so that they don't inline.
static bool SearchHistoryPreventInlining(
- AutocompleteInput::PageClassification current_page_classification);
+ AutocompleteInput::OmniboxContext omnibox_context);
// Returns true if the user is in the experiment group that, given the
- // provided |current_page_classification| context, disables all query
- // suggestions from search history.
+ // provided |omnibox_context|, disables all query suggestions from search
+ // history.
static bool SearchHistoryDisable(
- AutocompleteInput::PageClassification current_page_classification);
+ AutocompleteInput::OmniboxContext omnibox_context);
private:
FRIEND_TEST_ALL_PREFIXES(OmniboxFieldTrialTest, GetValueForRuleInContext);
@@ -130,7 +130,7 @@ class OmniboxFieldTrial {
//
// This function returns the value associated with the |rule| that applies
// in the current context (which currently only consists of
- // |page_classification| but will soon contain other features, some not
+ // |omnibox_context| but will soon contain other features, some not
// passed in as parameters, such as whether Instant Extended is enabled).
// If no such rule exists in the current context, looks for that rule in
// the global context and return its value if found. If the rule remains
@@ -139,7 +139,7 @@ class OmniboxFieldTrial {
// to the caller; this is rule-dependent.
static std::string GetValueForRuleInContext(
const std::string& rule,
- AutocompleteInput::PageClassification page_classification);
+ AutocompleteInput::OmniboxContext omnibox_context);
DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
};

Powered by Google App Engine
This is Rietveld 408576698