Issue 22311011: Improve 'performance.{mark,measure} exception messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22311011: Improve 'performance.{mark,measure} exception messages. (Closed)

Created:
7 years, 4 months ago by Mike West

Modified:
7 years, 4 months ago

Reviewers:
arv (Not doing code reviews)

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Improve 'performance.{mark,measure} exception messages. Rather than throwing the generic 'InvalidAccessError' and 'SyntaxError' text, this patch adds information about the reasons behind the throw in order to improve the developer experience. BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155880

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -3 lines)			Patch
A	LayoutTests/fast/performance/performance-mark-exceptions.html	View	1 chunk	+39 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/performance/performance-mark-exceptions-expected.txt	View	1 chunk	+30 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/performance/performance-measure-exceptions.html	View	1 chunk	+33 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/performance/performance-measure-exceptions-expected.txt	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	Source/core/page/PerformanceUserTiming.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/22311011/1

7 years, 4 months ago (2013-08-09 18:03:56 UTC) #3

Message was sent while issue was closed.

Change committed as 155880

Expand Messages | Collapse Messages