LayoutTests/fast/performance/performance-measure-exceptions.html - Issue 22311011: Improve 'performance.{mark,measure} exception messages.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/performance/performance-measure-exceptions.html

Issue 22311011: Improve 'performance.{mark,measure} exception messages. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 </head>

	5 <body>

	6 <script src="../js/resources/js-test-pre.js"></script>

	7 <script>

	8 description("This tests that 'performance.measure' throws exceptions wit h reasonable messages.");

	9

	10 shouldThrow('window.performance.measure("DoesNotExist", "AlsoDoesNotExis t")', '"SyntaxError: The mark \'AlsoDoesNotExist\' does not exist."');

	11

	12 window.performance.mark('mark');

	13

	14 var allTheExceptionalThings = [

	15 'unloadEventStart',

	16 'unloadEventEnd',

	17 'redirectStart',

	18 'redirectEnd',

	19 'secureConnectionStart',

	20 'domInteractive',

	21 'domContentLoadedEventStart',

	22 'domContentLoadedEventEnd',

	23 'domComplete',

	24 'loadEventStart',

	25 'loadEventEnd',

	26 ];

	27 allTheExceptionalThings.forEach(function(name) {

	28 shouldThrow('window.performance.measure("measuring", \'' + name + '\ ', "mark")', '"InvalidAccessError: \'' + name + '\' is empty: either the event h asn\'t happened yet, or it would provide cross-origin timing information."');

	29 });

	30 </script>

	31 <script src="../js/resources/js-test-post.js"></script>

	32 </body>

	33 </html>

OLD	NEW