third_party/WebKit/Source/bindings/core/v8/V8Binding.h - Issue 2227933002: Revert CompressibleString (and its UMA)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.h

Issue 2227933002: Revert CompressibleString (and its UMA) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address on Ilya's review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h

index 35a426b533ef31e41da6d2e66912d3e3f4a81441..004d117cdf342507c690aef9e70ea22916a9239e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h

@@ -48,7 +48,6 @@

#include "bindings/core/v8/V8ValueCache.h"

#include "core/CoreExport.h"

#include "platform/heap/Handle.h"

-#include "platform/text/CompressibleString.h"

#include "wtf/text/AtomicString.h"

#include "wtf/text/StringView.h"

#include <v8.h>

@@ -415,13 +414,6 @@ inline v8::Local<v8::Value> v8StringOrNull(v8::Isolate* isolate, const AtomicStr

return V8PerIsolateData::from(isolate)->getStringCache()->v8ExternalString(isolate, string.impl());

}

-inline v8::Local<v8::String> v8String(v8::Isolate* isolate, const CompressibleString& string)

- if (string.isNull())

- return v8::String::Empty(isolate);

- return V8PerIsolateData::from(isolate)->getStringCache()->v8ExternalString(isolate, string);

inline v8::Local<v8::String> v8AtomicString(v8::Isolate* isolate, const StringView& string)

{

DCHECK(isolate);