extensions/common/permissions/media_galleries_permission.h - Issue 221353003: Make unknown extension subpermissions warnings instead of errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/media_galleries_permission.h

Issue 221353003: Make unknown extension subpermissions warnings instead of errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/permissions/media_galleries_permission.h

diff --git a/extensions/common/permissions/media_galleries_permission.h b/extensions/common/permissions/media_galleries_permission.h

index 36b6dba456a81a059766d07c788d4e2ddeeeaf58..cade51f12e3cda3c04bb853361da5ecea32ee6bd 100644

--- a/extensions/common/permissions/media_galleries_permission.h

+++ b/extensions/common/permissions/media_galleries_permission.h

@@ -38,7 +38,10 @@ class MediaGalleriesPermission

// SetDisjunctionPermission overrides.

// MediaGalleriesPermission does additional checks to make sure the

// permissions do not contain unknown values.

- virtual bool FromValue(const base::Value* value, std::string* error) OVERRIDE;

+ virtual bool FromValue(

+ const base::Value* value,

+ std::string* error,

+ std::vector<std::string>* unhandled_permissions) OVERRIDE;

// APIPermission overrides.

virtual PermissionMessages GetMessages() const OVERRIDE;