Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: extensions/common/permissions/media_galleries_permission.h

Issue 221353003: Make unknown extension subpermissions warnings instead of errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_PERMISSIONS_MEDIA_GALLERIES_PERMISSION_H_ 5 #ifndef EXTENSIONS_COMMON_PERMISSIONS_MEDIA_GALLERIES_PERMISSION_H_
6 #define EXTENSIONS_COMMON_PERMISSIONS_MEDIA_GALLERIES_PERMISSION_H_ 6 #define EXTENSIONS_COMMON_PERMISSIONS_MEDIA_GALLERIES_PERMISSION_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "extensions/common/permissions/api_permission.h" 9 #include "extensions/common/permissions/api_permission.h"
10 #include "extensions/common/permissions/media_galleries_permission_data.h" 10 #include "extensions/common/permissions/media_galleries_permission_data.h"
(...skipping 20 matching lines...) Expand all
31 : permission(permission) {} 31 : permission(permission) {}
32 const std::string permission; 32 const std::string permission;
33 }; 33 };
34 34
35 explicit MediaGalleriesPermission(const APIPermissionInfo* info); 35 explicit MediaGalleriesPermission(const APIPermissionInfo* info);
36 virtual ~MediaGalleriesPermission(); 36 virtual ~MediaGalleriesPermission();
37 37
38 // SetDisjunctionPermission overrides. 38 // SetDisjunctionPermission overrides.
39 // MediaGalleriesPermission does additional checks to make sure the 39 // MediaGalleriesPermission does additional checks to make sure the
40 // permissions do not contain unknown values. 40 // permissions do not contain unknown values.
41 virtual bool FromValue(const base::Value* value, std::string* error) OVERRIDE; 41 virtual bool FromValue(
42 const base::Value* value,
43 std::string* error,
44 std::vector<std::string>* unhandled_permissions) OVERRIDE;
42 45
43 // APIPermission overrides. 46 // APIPermission overrides.
44 virtual PermissionMessages GetMessages() const OVERRIDE; 47 virtual PermissionMessages GetMessages() const OVERRIDE;
45 48
46 // Permission strings. 49 // Permission strings.
47 static const char kAllAutoDetectedPermission[]; 50 static const char kAllAutoDetectedPermission[];
48 static const char kScanPermission[]; 51 static const char kScanPermission[];
49 static const char kReadPermission[]; 52 static const char kReadPermission[];
50 static const char kCopyToPermission[]; 53 static const char kCopyToPermission[];
51 static const char kDeletePermission[]; 54 static const char kDeletePermission[];
52 }; 55 };
53 56
54 } // namespace extensions 57 } // namespace extensions
55 58
56 #endif // EXTENSIONS_COMMON_PERMISSIONS_MEDIA_GALLERIES_PERMISSION_H_ 59 #endif // EXTENSIONS_COMMON_PERMISSIONS_MEDIA_GALLERIES_PERMISSION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698