Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: extensions/common/permissions/api_permission_set_unittest.cc

Issue 221353003: Make unknown extension subpermissions warnings instead of errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/api_permission_set_unittest.cc
diff --git a/extensions/common/permissions/api_permission_set_unittest.cc b/extensions/common/permissions/api_permission_set_unittest.cc
index f57f8823483409053b0c2e32bf018cb35f4faffd..e007d5b51487e8fdd0117d5fd34f021493c2ebed 100644
--- a/extensions/common/permissions/api_permission_set_unittest.cc
+++ b/extensions/common/permissions/api_permission_set_unittest.cc
@@ -48,7 +48,7 @@ TEST(APIPermissionSetTest, CreateUnion) {
value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
// Union with an empty set.
@@ -81,7 +81,7 @@ TEST(APIPermissionSetTest, CreateUnion) {
scoped_ptr<base::ListValue> value(new base::ListValue());
value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
value->Append(new base::StringValue("udp-send-to::8899"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis2.insert(permission);
@@ -97,7 +97,7 @@ TEST(APIPermissionSetTest, CreateUnion) {
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
value->Append(new base::StringValue("udp-send-to::8899"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
// Insert a new socket permission which will replace the old one.
expected_apis.insert(permission);
@@ -134,7 +134,7 @@ TEST(APIPermissionSetTest, CreateIntersection) {
value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis1.insert(permission);
@@ -160,7 +160,7 @@ TEST(APIPermissionSetTest, CreateIntersection) {
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
value->Append(new base::StringValue("udp-send-to::8899"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis2.insert(permission);
@@ -170,7 +170,7 @@ TEST(APIPermissionSetTest, CreateIntersection) {
scoped_ptr<base::ListValue> value(new base::ListValue());
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
expected_apis.insert(permission);
@@ -206,7 +206,7 @@ TEST(APIPermissionSetTest, CreateDifference) {
value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis1.insert(permission);
@@ -224,7 +224,7 @@ TEST(APIPermissionSetTest, CreateDifference) {
scoped_ptr<base::ListValue> value(new base::ListValue());
value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
value->Append(new base::StringValue("udp-send-to::8899"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis2.insert(permission);
@@ -234,7 +234,7 @@ TEST(APIPermissionSetTest, CreateDifference) {
scoped_ptr<base::ListValue> value(new base::ListValue());
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
expected_apis.insert(permission);
@@ -268,7 +268,7 @@ TEST(APIPermissionSetTest, IPC) {
value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
- ASSERT_TRUE(permission->FromValue(value.get(), NULL));
+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis.insert(permission);
« no previous file with comments | « extensions/common/permissions/api_permission_set.cc ('k') | extensions/common/permissions/media_galleries_permission.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698