Refactoring: Make Resource::m_data private

Refactoring: Make Resource::m_data private

This CL makes Resource::m_data private to improve code health.

After this CL, all protected member vairables in Resource will be
changed to private.

BUG=n/a
TEST=webkit_unit_tests

Committed: https://crrev.com/8954d05887aba9640fa2621329622dfc2a0ba013
Cr-Commit-Position: refs/heads/master@{#410013}

[hajimehoshi, 2016-08-02 08:24:13]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 08:24:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hajimehoshi, 2016-08-02 08:25:38]

hajimehoshi@chromium.org changed reviewers:
+ hiroshige@chromium.org, mkwst@chromium.org

[hajimehoshi, 2016-08-02 08:25:39]

PTAL

[hiroshige, 2016-08-02 08:37:09]

1. Replacing m_data with resourceBuffer() in many locations introduces
additional ref()/deref()s to SharedBuffer, because resourceBuffer() returns
PassRefPtr.
2. Probably we cannot replace m_data with resourceBuffer() in ImageResource,
because ImageResource::resourceBuffer() does more than accessing m_data.

[hajimehoshi, 2016-08-02 08:44:40]

On 2016/08/02 08:37:09, hiroshige wrote:
> 1. Replacing m_data with resourceBuffer() in many locations introduces
> additional ref()/deref()s to SharedBuffer, because resourceBuffer() returns
> PassRefPtr.
> 2. Probably we cannot replace m_data with resourceBuffer() in ImageResource,
> because ImageResource::resourceBuffer() does more than accessing m_data.

Hmm, I was wondering why we wouldn't be able to replace this in ImageResource.
Isn't it possible even if we add a new function to return a raw pointer to
SharedBuffer?

[commit-bot: I haz the power, 2016-08-02 09:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 09:34:00]

Dry run: This issue passed the CQ dry run.

[hajimehoshi, 2016-08-03 07:00:11]

PTAL

[hajimehoshi, 2016-08-03 07:00:25]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 07:00:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-08-03 07:28:35]

On 2016/08/03 07:00:11, hajimehoshi wrote:
> PTAL

lgtm.

[commit-bot: I haz the power, 2016-08-03 08:44:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 08:44:31]

Dry run: This issue passed the CQ dry run.

[Mike West, 2016-08-04 12:42:03]

LGTM.

[hajimehoshi, 2016-08-05 05:01:08]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2016-08-05 05:01:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 06:46:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 06:46:38]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[hajimehoshi, 2016-08-05 06:58:22]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2016-08-05 06:58:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 07:29:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-05 07:32:58]

Description was changed from

==========
Refactoring: Make Resource::m_data private

This CL makes Resource::m_data private to improve code health.

After this CL, all protected member vairables in Resource will be
changed to private.

BUG=n/a
TEST=webkit_unit_tests
==========

to

==========
Refactoring: Make Resource::m_data private

This CL makes Resource::m_data private to improve code health.

After this CL, all protected member vairables in Resource will be
changed to private.

BUG=n/a
TEST=webkit_unit_tests

Committed: https://crrev.com/8954d05887aba9640fa2621329622dfc2a0ba013
Cr-Commit-Position: refs/heads/master@{#410013}
==========

[commit-bot: I haz the power, 2016-08-05 07:32:59]

Patchset 3 (id:??) landed as
https://crrev.com/8954d05887aba9640fa2621329622dfc2a0ba013
Cr-Commit-Position: refs/heads/master@{#410013}