Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Side by Side Diff: third_party/WebKit/Source/core/fetch/ScriptResource.cpp

Issue 2202173002: Refactoring: Make Resource::m_data private (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address on hiroshige's review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org) 3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org) 4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
6 Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 7
8 This library is free software; you can redistribute it and/or 8 This library is free software; you can redistribute it and/or
9 modify it under the terms of the GNU Library General Public 9 modify it under the terms of the GNU Library General Public
10 License as published by the Free Software Foundation; either 10 License as published by the Free Software Foundation; either
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 auto dump = memoryDump->createMemoryAllocatorDump(name); 78 auto dump = memoryDump->createMemoryAllocatorDump(name);
79 dump->addScalar("size", "bytes", m_script.currentSizeInBytes()); 79 dump->addScalar("size", "bytes", m_script.currentSizeInBytes());
80 memoryDump->addSuballocation(dump->guid(), String(WTF::Partitions::kAllocate dObjectPoolName)); 80 memoryDump->addSuballocation(dump->guid(), String(WTF::Partitions::kAllocate dObjectPoolName));
81 } 81 }
82 82
83 const CompressibleString& ScriptResource::script() 83 const CompressibleString& ScriptResource::script()
84 { 84 {
85 ASSERT(!isPurgeable()); 85 ASSERT(!isPurgeable());
86 ASSERT(isLoaded()); 86 ASSERT(isLoaded());
87 87
88 if (m_script.isNull() && m_data) { 88 if (m_script.isNull() && data()) {
89 String script = decodedText(); 89 String script = decodedText();
90 m_data.clear(); 90 clearData();
91 // We lie a it here and claim that script counts as encoded data (even t hough it's really decoded data). 91 // We lie a it here and claim that script counts as encoded data (even t hough it's really decoded data).
92 // That's because the MemoryCache thinks that it can clear out decoded d ata by calling destroyDecodedData(), 92 // That's because the MemoryCache thinks that it can clear out decoded d ata by calling destroyDecodedData(),
93 // but we can't destroy script in destroyDecodedData because that's our only copy of the data! 93 // but we can't destroy script in destroyDecodedData because that's our only copy of the data!
94 setEncodedSize(script.sizeInBytes()); 94 setEncodedSize(script.sizeInBytes());
95 m_script = CompressibleString(script.impl()); 95 m_script = CompressibleString(script.impl());
96 } 96 }
97 97
98 return m_script; 98 return m_script;
99 } 99 }
100 100
(...skipping 14 matching lines...) Expand all
115 } 115 }
116 bool ScriptResource::mustRefetchDueToIntegrityMetadata(const FetchRequest& reque st) const 116 bool ScriptResource::mustRefetchDueToIntegrityMetadata(const FetchRequest& reque st) const
117 { 117 {
118 if (request.integrityMetadata().isEmpty()) 118 if (request.integrityMetadata().isEmpty())
119 return false; 119 return false;
120 120
121 return !IntegrityMetadata::setsEqual(m_integrityMetadata, request.integrityM etadata()); 121 return !IntegrityMetadata::setsEqual(m_integrityMetadata, request.integrityM etadata());
122 } 122 }
123 123
124 } // namespace blink 124 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/fetch/Resource.h ('k') | third_party/WebKit/Source/core/fetch/TextResource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698