third_party/WebKit/Source/core/fetch/Resource.h - Issue 2202173002: Refactoring: Make Resource::m_data private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 2202173002: Refactoring: Make Resource::m_data private (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address on hiroshige's review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/Resource.h

diff --git a/third_party/WebKit/Source/core/fetch/Resource.h b/third_party/WebKit/Source/core/fetch/Resource.h

index aa38dcd8db673802763783fb5706cc9a8d7ce5ff..471249d76b8b0c592d62abc1705f79024817585b 100644

--- a/third_party/WebKit/Source/core/fetch/Resource.h

+++ b/third_party/WebKit/Source/core/fetch/Resource.h

@@ -294,7 +294,8 @@ protected:

void setCachePolicyBypassingCache();

void setLoFiStateOff();

- RefPtr<SharedBuffer> m_data;

+ SharedBuffer* data() const { return m_data.get(); }

+ void clearData() { m_data.clear(); }

private:

class ResourceCallback;

@@ -360,6 +361,8 @@ private:

ResourceRequest m_resourceRequest;

Member<ResourceLoader> m_loader;

ResourceResponse m_response;

+ RefPtr<SharedBuffer> m_data;

};

class ResourceFactory {