Reland 2:Geolocation: move from content/browser to device/

Reland 2:Geolocation: move from content/browser to device/

Reland was reverted due to a build failure in an official win64 builder
that hit the infamous size_t to int conversion warning [1]:

FAILED: obj/device/geolocation/device_geolocation.network_location_request.obj
ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\device\geolocation\device_geolocation.network_location_request.obj.rsp /c ..\..\device\geolocation\network_location_request.cc /Foobj\device\geolocation\device_geolocation.network_location_request.obj /Fdobj\device\geolocation\device_geolocation.cc.pdb
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data

[1] https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/1125/steps/compile/logs/stdio/text

Original Reland description --------------------------------------------

Original CL was reverted because it broke Win Gyp Component-build
bot(s). This CL (PS2) defines the geolocation gyp component
correctly.

Original CL description ------------------------------------------------
Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn  and
 geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace.

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks:
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.

BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pstew@chromium.org
rationale:device/geolocation depends on dbus and this triggers
a DEPS presubmit rule -- however, this CL adds no new dependencies,
hence moving on in the interest of speed (and avoiding more rebases).

Committed: https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08
Cr-Commit-Position: refs/heads/master@{#408393}

[mcasas, 2016-07-28 03:40:43]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 03:41:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 04:30:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 04:30:35]

Dry run: This issue passed the CQ dry run.

[mcasas, 2016-07-28 15:03:37]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-07-28 15:03:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 15:11:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-28 15:12:49]

Description was changed from

==========
Reland 2:Geolocation: move from content/browser to device/

Reland was reverted due to a build failure in an official win64 builder
that hit the infamous size_t to int conversion warning [1]:

FAILED: obj/device/geolocation/device_geolocation.network_location_request.obj
ninja -t msvc -e environment.x64 --
"C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe"
/nologo /showIncludes /FC
@obj\device\geolocation\device_geolocation.network_location_request.obj.rsp /c
..\..\device\geolocation\network_location_request.cc
/Foobj\device\geolocation\device_geolocation.network_location_request.obj
/Fdobj\device\geolocation\device_geolocation.cc.pdb
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119):
error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119):
warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of
data

[1]
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/w...


Original Reland description --------------------------------------------

Original CL was reverted because it broke Win Gyp Component-build
bot(s). This CL (PS2) defines the geolocation gyp component
correctly.

Original CL description ------------------------------------------------
Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn  and
 geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace.

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks:
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.

BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pstew@chromium.org
rationale:device/geolocation depends on dbus and this triggers
a DEPS presubmit rule -- however, this CL adds no new dependencies,
hence moving on in the interest of speed (and avoiding more rebases).
==========

to

==========
Reland 2:Geolocation: move from content/browser to device/

Reland was reverted due to a build failure in an official win64 builder
that hit the infamous size_t to int conversion warning [1]:

FAILED: obj/device/geolocation/device_geolocation.network_location_request.obj
ninja -t msvc -e environment.x64 --
"C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe"
/nologo /showIncludes /FC
@obj\device\geolocation\device_geolocation.network_location_request.obj.rsp /c
..\..\device\geolocation\network_location_request.cc
/Foobj\device\geolocation\device_geolocation.network_location_request.obj
/Fdobj\device\geolocation\device_geolocation.cc.pdb
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119):
error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119):
warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of
data

[1]
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/w...

Original Reland description --------------------------------------------

Original CL was reverted because it broke Win Gyp Component-build
bot(s). This CL (PS2) defines the geolocation gyp component
correctly.

Original CL description ------------------------------------------------
Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn  and
 geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace.

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks:
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.

BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pstew@chromium.org
rationale:device/geolocation depends on dbus and this triggers
a DEPS presubmit rule -- however, this CL adds no new dependencies,
hence moving on in the interest of speed (and avoiding more rebases).

Committed: https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08
Cr-Commit-Position: refs/heads/master@{#408393}
==========

[commit-bot: I haz the power, 2016-07-28 15:12:52]

Patchset 2 (id:??) landed as
https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08
Cr-Commit-Position: refs/heads/master@{#408393}

[Dirk Pranke, 2016-07-28 15:33:21]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2192863002/ by dpranke@chromium.org.

The reason for reverting is: Looks like this still breaks things:

http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builde...

https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi....