Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4270)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/resources/ui_resource_request.cc

Issue 2154473004: Add a sanity DCHECK when constructing a UIResourceRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a check that we're deleting when no bitmap is passed to the constructor. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/trees/layer_tree_host_impl.cc » ('j') | cc/trees/layer_tree_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/ui_resource_request.cc
diff --git a/cc/resources/ui_resource_request.cc b/cc/resources/ui_resource_request.cc
index 28fd7f3602f79ce7c558aebcd540c45e9f60749c..a51e307bff6e102b4b5945bf831a9371ebfcdd02 100644
--- a/cc/resources/ui_resource_request.cc
+++ b/cc/resources/ui_resource_request.cc
@@ -10,7 +10,9 @@ namespace cc {
UIResourceRequest::UIResourceRequest(UIResourceRequestType type,
UIResourceId id)
- : type_(type), id_(id) {}
+ : type_(type), id_(id) {
+ DCHECK(type == UIResourceRequestType.DELETE);
vmpstr 2016/07/15 21:29:23 This should be UI_RESOURCE_DELETE, right? from htt
Donn Denman 2016/07/15 22:05:56 Gee, how did that even compile? I'm pretty sure I
+}
UIResourceRequest::UIResourceRequest(UIResourceRequestType type,
UIResourceId id,
« no previous file with comments | « no previous file | cc/trees/layer_tree_host_impl.cc » ('j') | cc/trees/layer_tree_host_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698