Add a sanity DCHECK when constructing a UIResourceRequest.

cc/resources/ui_resource_request.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/ui_resource_request.h"
 
 #include "base/memory/ptr_util.h"
 
 namespace cc {
 
 UIResourceRequest::UIResourceRequest(UIResourceRequestType type,
                                      UIResourceId id)
-    : type_(type), id_(id) {}
+    : type_(type), id_(id) {
+  DCHECK(type == UIResourceRequestType.DELETE);

[vmpstr, 2016/07/15 21:29:23]

This should be UI_RESOURCE_DELETE, right? from
https://cs.chromium.org/chromium/src/cc/resources/ui_resource_request.h?q=UIR...

[Donn Denman, 2016/07/15 22:05:56]

Gee, how did that even compile?  I'm pretty sure I compiled and tested, but this
makes me think that didn't get done.  How sloppy!

Thanks for the catch.  Done.

+}
 
 UIResourceRequest::UIResourceRequest(UIResourceRequestType type,
                                      UIResourceId id,
                                      const UIResourceBitmap& bitmap)
     : type_(type), id_(id), bitmap_(new UIResourceBitmap(bitmap)) {}
 
 UIResourceRequest::UIResourceRequest(const UIResourceRequest& request) {
   (*this) = request;
 }
 
 UIResourceRequest& UIResourceRequest::operator=(
     const UIResourceRequest& request) {
   type_ = request.type_;
   id_ = request.id_;
   if (request.bitmap_) {
     bitmap_ = base::WrapUnique(new UIResourceBitmap(*request.bitmap_.get()));
   } else {
     bitmap_ = nullptr;
   }
 
   return *this;
 }
 
 UIResourceRequest::~UIResourceRequest() {}
 
 }  // namespace cc