cc/trees/layer_tree_host_impl.cc - Issue 2154473004: Add a sanity DCHECK when constructing a UIResourceRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 2154473004: Add a sanity DCHECK when constructing a UIResourceRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a check that we're deleting when no bitmap is passed to the constructor. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/layer_tree_host_impl.cc

diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc

index fc3065b462bf515dae314a16ebc48e2387c2a22e..b649463cfe3b9a6ecfd056aab83135dc16d65e27 100644

--- a/cc/trees/layer_tree_host_impl.cc

+++ b/cc/trees/layer_tree_host_impl.cc

@@ -3681,6 +3681,7 @@ void LayerTreeHostImpl::SetDebugState(

void LayerTreeHostImpl::CreateUIResource(UIResourceId uid,

const UIResourceBitmap& bitmap) {

DCHECK_GT(uid, 0);

+ DCHECK(&bitmap);

vmpstr 2016/07/15 21:29:23 This shouldn't be here. We should be DCHECKing at

Donn Denman 2016/07/15 22:05:56 Removed.

// Allow for multiple creation requests with the same UIResourceId. The

// previous resource is simply deleted.

« cc/resources/ui_resource_request.cc ('K') | « cc/resources/ui_resource_request.cc ('k') | cc/trees/layer_tree_impl.cc » ('j') | cc/trees/layer_tree_impl.cc » ('J')