avoid char+'\xHH' as it's too easy to use values > 127

avoid char+'\xHH' as it's too easy to use values > 127

TEST=net_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215124

[Mostyn Bramley-Moore, 2013-08-01 12:31:48]

@szym: followup from 21229002...

[szym, 2013-08-01 14:28:27]

Thanks for doing this!
LGTM with two suggestions.

https://codereview.chromium.org/21534003/diff/1/net/dns/mdns_client_unittest.cc
File net/dns/mdns_client_unittest.cc (right):

https://codereview.chromium.org/21534003/diff/1/net/dns/mdns_client_unittest....
net/dns/mdns_client_unittest.cc:433: std::string(reinterpret_cast<const
char*>(packet), size)))
This is done 4 times in this file. Suggest helper function:

std::string MakeString(const uint8* data, unsigned size) {
  return std::string(...);
}

https://codereview.chromium.org/21534003/diff/1/net/dns/record_rdata_unittest.cc
File net/dns/record_rdata_unittest.cc (right):

https://codereview.chromium.org/21534003/diff/1/net/dns/record_rdata_unittest...
net/dns/record_rdata_unittest.cc:38: base::StringPiece
record1_strpiece(record_cc, first_record_len);
This is done 8 times in this file. Suggest helper function:

base::StringPiece MakeStringPiece(const uint8* data, unsigned size) {
  return base::StringPiece(...);
}

[Mostyn Bramley-Moore, 2013-08-01 14:56:23]

https://codereview.chromium.org/21534003/diff/1/net/dns/mdns_client_unittest.cc
File net/dns/mdns_client_unittest.cc (right):

https://codereview.chromium.org/21534003/diff/1/net/dns/mdns_client_unittest....
net/dns/mdns_client_unittest.cc:433: std::string(reinterpret_cast<const
char*>(packet), size)))
On 2013/08/01 14:28:27, szym wrote:
> This is done 4 times in this file. Suggest helper function:
> 
> std::string MakeString(const uint8* data, unsigned size) {
>   return std::string(...);
> }

Done.

https://codereview.chromium.org/21534003/diff/1/net/dns/record_rdata_unittest.cc
File net/dns/record_rdata_unittest.cc (right):

https://codereview.chromium.org/21534003/diff/1/net/dns/record_rdata_unittest...
net/dns/record_rdata_unittest.cc:38: base::StringPiece
record1_strpiece(record_cc, first_record_len);
On 2013/08/01 14:28:27, szym wrote:
> This is done 8 times in this file. Suggest helper function:
> 
> base::StringPiece MakeStringPiece(const uint8* data, unsigned size) {
>   return base::StringPiece(...);
> }

Done.

[szym, 2013-08-01 15:43:19]

lgtm

[commit-bot: I haz the power, 2013-08-01 15:43:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/21534003/7001

[commit-bot: I haz the power, 2013-08-01 16:15:00]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[szym, 2013-08-01 16:18:43]

You'll also need to fix the two unittest files in
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/utility/loc...


On Thu, Aug 1, 2013 at 12:15 PM, <commit-bot@chromium.org> wrote:

> Sorry for I got bad news for ya.
> Compile failed with a clobber build on linux_aura.
> http://build.chromium.org/p/**tryserver.chromium/**
>
buildstatus?builder=linux_**aura&number=65264<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=65264>
> Your code is likely broken or HEAD is junk. Please ensure your
> code is not broken then alert the build sheriffs.
> Look at the try server FAQ for more details.
>
>
https://chromiumcodereview.**appspot.com/21534003/<https://chromiumcodereview...
>

[Mostyn Bramley-Moore, 2013-08-01 16:30:10]

On 2013/08/01 16:18:43, szym wrote:
> You'll also need to fix the two unittest files in
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/utility/loc...

Done.

[szym, 2013-08-01 16:31:12]

lgtm
noamsml: PTAL

[Noam Samuel, 2013-08-01 16:49:40]

On 2013/08/01 16:31:12, szym wrote:
> lgtm
> noamsml: PTAL

lgtm

[commit-bot: I haz the power, 2013-08-01 16:57:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/21534003/34001

[commit-bot: I haz the power, 2013-08-01 21:52:25]

Change committed as 215124