avoid char+'\xHH' as it's too easy to use values > 127

net/dns/record_parsed_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/record_parsed.h"
 
 #include "net/dns/dns_protocol.h"
 #include "net/dns/dns_response.h"
 #include "net/dns/dns_test_util.h"
 #include "net/dns/record_rdata.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
-static const char kT1ResponseWithCacheFlushBit[] = {
-  '\x0a', 'c', 'o', 'd', 'e', 'r', 'e', 'v', 'i', 'e', 'w',
-  '\x08', 'c', 'h', 'r', 'o', 'm', 'i', 'u', 'm',
-  '\x03', 'o', 'r', 'g',
-  '\x00',
-  '\x00', '\x05',        // TYPE is CNAME.
-  '\x80', '\x01',        // CLASS is IN with cache flush bit set.
-  '\x00', '\x01',        // TTL (4 bytes) is 20 hours, 47 minutes, 48 seconds.
-  '\x24', '\x74',
-  '\x00', '\x12',        // RDLENGTH is 18 bytes.
+static const uint8 kT1ResponseWithCacheFlushBit[] = {
+  0x0a, 'c', 'o', 'd', 'e', 'r', 'e', 'v', 'i', 'e', 'w',
+  0x08, 'c', 'h', 'r', 'o', 'm', 'i', 'u', 'm',
+  0x03, 'o', 'r', 'g',
+  0x00,
+  0x00, 0x05,        // TYPE is CNAME.
+  0x80, 0x01,        // CLASS is IN with cache flush bit set.
+  0x00, 0x01,        // TTL (4 bytes) is 20 hours, 47 minutes, 48 seconds.
+  0x24, 0x74,
+  0x00, 0x12,        // RDLENGTH is 18 bytes.
   // ghs.l.google.com in DNS format.
-  '\x03', 'g', 'h', 's',
-  '\x01', 'l',
-  '\x06', 'g', 'o', 'o', 'g', 'l', 'e',
-  '\x03', 'c', 'o', 'm',
-  '\x00'
+  0x03, 'g', 'h', 's',
+  0x01, 'l',
+  0x06, 'g', 'o', 'o', 'g', 'l', 'e',
+  0x03, 'c', 'o', 'm',
+  0x00
 };
 
 TEST(RecordParsedTest, ParseSingleRecord) {
   DnsRecordParser parser(kT1ResponseDatagram, sizeof(kT1ResponseDatagram),
                          sizeof(dns_protocol::Header));
   scoped_ptr<const RecordParsed> record;
   const CnameRecordRdata* rdata;
 
   parser.SkipQuestion();
   record = RecordParsed::CreateFrom(&parser, base::Time());
@@ skipping 25 matching lines @@
   scoped_ptr<const RecordParsed> record2 =
       RecordParsed::CreateFrom(&parser2, base::Time());
 
   EXPECT_FALSE(record1->IsEqual(record2.get(), false));
   EXPECT_TRUE(record1->IsEqual(record2.get(), true));
   EXPECT_FALSE(record2->IsEqual(record1.get(), false));
   EXPECT_TRUE(record2->IsEqual(record1.get(), true));
 }
 
 }  //namespace net