net/dns/mock_mdns_socket_factory.h - Issue 21534003: avoid char+'\xHH' as it's too easy to use values > 127

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/mock_mdns_socket_factory.h

Issue 21534003: avoid char+'\xHH' as it's too easy to use values > 127 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: corresponding change in chrome unit tests Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/mock_mdns_socket_factory.h

diff --git a/net/dns/mock_mdns_socket_factory.h b/net/dns/mock_mdns_socket_factory.h

index 62f6b7e542554aae12522c7b1d143390b8fce048..f60b08c591bd50ced5152009fbad0e1e255b1fae 100644

--- a/net/dns/mock_mdns_socket_factory.h

+++ b/net/dns/mock_mdns_socket_factory.h

@@ -77,7 +77,7 @@ class MockMDnsSocketFactory : public MDnsConnection::SocketFactory {

virtual scoped_ptr<DatagramServerSocket> CreateSocket() OVERRIDE;

- void SimulateReceive(const char* packet, int size);

+ void SimulateReceive(const uint8* packet, int size);

MOCK_METHOD1(OnSendTo, void(const std::string&));

« no previous file with comments | « net/dns/mdns_client_unittest.cc ('k') | net/dns/mock_mdns_socket_factory.cc » ('j') | no next file with comments »