Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2150443002: Supplement should have a Member to the corresponding Supplementable object (Part 1)

Created:
4 years, 5 months ago by haraken
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, mlamouri+watch-blink_chromium.org, ortuno+watch_chromium.org, rwlbuis, scheib+watch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Supplement should have a Member to the corresponding Supplementable object (Part 1) If Supplement has a Member to the corresponding Supplementable object, we can remove a bunch of LifecycleObservers (because the Supplement object can get the Supplementable object without observing the Supplementable object). We should add the Member. BUG=627723

Patch Set 1 #

Total comments: 6

Patch Set 2 : temp #

Total comments: 3

Patch Set 3 : temp #

Patch Set 4 : temp #

Total comments: 1

Patch Set 5 : temp #

Patch Set 6 : temp #

Patch Set 7 : temp #

Patch Set 8 : temp #

Patch Set 9 : temp #

Patch Set 10 : temp #

Patch Set 11 : temp #

Patch Set 12 : temp #

Patch Set 13 : temp #

Patch Set 14 : temp #

Patch Set 15 : temp #

Patch Set 16 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -49 lines) Patch
M third_party/WebKit/Source/core/dom/CSSSelectorWatch.h View 1 2 3 4 5 6 7 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp View 1 2 3 4 5 6 7 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxyClient.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxyClient.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Navigator.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/NavigatorID.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/NavigatorLanguage.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Screen.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/DOMWindowPerformance.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerNavigator.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothSupplement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothSupplement.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h View 1 2 3 4 5 6 7 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/installedapp/InstalledAppController.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/NavigatorVibration.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Supplementable.h View 1 2 4 2 chunks +13 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/AudioOutputDeviceClientImpl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/AudioOutputDeviceClientImpl.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/CompositorProxyClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/CompositorProxyClientImpl.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetBase.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.cpp View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameWidget.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 81 (42 generated)
haraken
PTAL
4 years, 5 months ago (2016-07-13 07:15:49 UTC) #2
sof
https://codereview.chromium.org/2150443002/diff/1/third_party/WebKit/Source/platform/Supplementable.h File third_party/WebKit/Source/platform/Supplementable.h (right): https://codereview.chromium.org/2150443002/diff/1/third_party/WebKit/Source/platform/Supplementable.h#newcode123 third_party/WebKit/Source/platform/Supplementable.h:123: WeakMember<T> m_host; Thinking about this some more, what value ...
4 years, 5 months ago (2016-07-13 07:20:41 UTC) #3
haraken
https://codereview.chromium.org/2150443002/diff/1/third_party/WebKit/Source/platform/Supplementable.h File third_party/WebKit/Source/platform/Supplementable.h (right): https://codereview.chromium.org/2150443002/diff/1/third_party/WebKit/Source/platform/Supplementable.h#newcode123 third_party/WebKit/Source/platform/Supplementable.h:123: WeakMember<T> m_host; On 2016/07/13 07:20:41, sof wrote: > Thinking ...
4 years, 5 months ago (2016-07-13 07:24:26 UTC) #4
sof
https://codereview.chromium.org/2150443002/diff/1/third_party/WebKit/Source/platform/Supplementable.h File third_party/WebKit/Source/platform/Supplementable.h (right): https://codereview.chromium.org/2150443002/diff/1/third_party/WebKit/Source/platform/Supplementable.h#newcode123 third_party/WebKit/Source/platform/Supplementable.h:123: WeakMember<T> m_host; On 2016/07/13 07:24:26, haraken wrote: > On ...
4 years, 5 months ago (2016-07-13 07:39:41 UTC) #5
sof
https://codereview.chromium.org/2150443002/diff/1/third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp File third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp (right): https://codereview.chromium.org/2150443002/diff/1/third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp#newcode49 third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp:49: , m_document(document) Do you need m_document any longer?
4 years, 5 months ago (2016-07-13 07:41:57 UTC) #6
haraken
https://codereview.chromium.org/2150443002/diff/1/third_party/WebKit/Source/platform/Supplementable.h File third_party/WebKit/Source/platform/Supplementable.h (right): https://codereview.chromium.org/2150443002/diff/1/third_party/WebKit/Source/platform/Supplementable.h#newcode123 third_party/WebKit/Source/platform/Supplementable.h:123: WeakMember<T> m_host; On 2016/07/13 07:39:41, sof wrote: > On ...
4 years, 5 months ago (2016-07-13 07:42:12 UTC) #7
haraken
https://codereview.chromium.org/2150443002/diff/1/third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp File third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp (right): https://codereview.chromium.org/2150443002/diff/1/third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp#newcode49 third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp:49: , m_document(document) On 2016/07/13 07:41:57, sof wrote: > Do ...
4 years, 5 months ago (2016-07-13 07:44:55 UTC) #8
sof
lgtm https://codereview.chromium.org/2150443002/diff/20001/third_party/WebKit/Source/core/dom/CSSSelectorWatch.h File third_party/WebKit/Source/core/dom/CSSSelectorWatch.h (right): https://codereview.chromium.org/2150443002/diff/20001/third_party/WebKit/Source/core/dom/CSSSelectorWatch.h#newcode63 third_party/WebKit/Source/core/dom/CSSSelectorWatch.h:63: Document& document() const { return *host(); } assert/check ...
4 years, 5 months ago (2016-07-13 07:46:09 UTC) #9
haraken
https://codereview.chromium.org/2150443002/diff/20001/third_party/WebKit/Source/core/dom/CSSSelectorWatch.h File third_party/WebKit/Source/core/dom/CSSSelectorWatch.h (right): https://codereview.chromium.org/2150443002/diff/20001/third_party/WebKit/Source/core/dom/CSSSelectorWatch.h#newcode63 third_party/WebKit/Source/core/dom/CSSSelectorWatch.h:63: Document& document() const { return *host(); } On 2016/07/13 ...
4 years, 5 months ago (2016-07-13 07:51:25 UTC) #10
sof
https://codereview.chromium.org/2150443002/diff/20001/third_party/WebKit/Source/core/dom/CSSSelectorWatch.h File third_party/WebKit/Source/core/dom/CSSSelectorWatch.h (right): https://codereview.chromium.org/2150443002/diff/20001/third_party/WebKit/Source/core/dom/CSSSelectorWatch.h#newcode63 third_party/WebKit/Source/core/dom/CSSSelectorWatch.h:63: Document& document() const { return *host(); } On 2016/07/13 ...
4 years, 5 months ago (2016-07-13 07:54:07 UTC) #11
haraken
On 2016/07/13 07:54:07, sof wrote: > https://codereview.chromium.org/2150443002/diff/20001/third_party/WebKit/Source/core/dom/CSSSelectorWatch.h > File third_party/WebKit/Source/core/dom/CSSSelectorWatch.h (right): > > https://codereview.chromium.org/2150443002/diff/20001/third_party/WebKit/Source/core/dom/CSSSelectorWatch.h#newcode63 > ...
4 years, 5 months ago (2016-07-13 08:11:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150443002/40001
4 years, 5 months ago (2016-07-13 08:11:49 UTC) #15
sof
On 2016/07/13 08:11:24, haraken wrote: > On 2016/07/13 07:54:07, sof wrote: > > > https://codereview.chromium.org/2150443002/diff/20001/third_party/WebKit/Source/core/dom/CSSSelectorWatch.h ...
4 years, 5 months ago (2016-07-13 08:16:18 UTC) #16
sof
On 2016/07/13 08:16:18, sof wrote: > On 2016/07/13 08:11:24, haraken wrote: > > On 2016/07/13 ...
4 years, 5 months ago (2016-07-13 08:17:00 UTC) #17
haraken
On 2016/07/13 08:17:00, sof wrote: > On 2016/07/13 08:16:18, sof wrote: > > On 2016/07/13 ...
4 years, 5 months ago (2016-07-13 08:18:44 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/217035)
4 years, 5 months ago (2016-07-13 08:21:28 UTC) #21
haraken
jochen@: PTAL at public/. This is just changing a signature of Blink-internal APIs.
4 years, 5 months ago (2016-07-13 08:23:14 UTC) #23
haraken
tkent@: Would you take a look at public/?
4 years, 5 months ago (2016-07-14 01:24:53 UTC) #25
tkent
https://codereview.chromium.org/2150443002/diff/60001/third_party/WebKit/public/web/WebFrameWidget.h File third_party/WebKit/public/web/WebFrameWidget.h (right): https://codereview.chromium.org/2150443002/diff/60001/third_party/WebKit/public/web/WebFrameWidget.h#newcode85 third_party/WebKit/public/web/WebFrameWidget.h:85: virtual CompositorProxyClient* createCompositorProxyClient(WorkerClients&) = 0; +dcheng. Exposing a core ...
4 years, 5 months ago (2016-07-14 01:33:04 UTC) #27
dcheng
On 2016/07/14 01:33:04, tkent wrote: > https://codereview.chromium.org/2150443002/diff/60001/third_party/WebKit/public/web/WebFrameWidget.h > File third_party/WebKit/public/web/WebFrameWidget.h (right): > > https://codereview.chromium.org/2150443002/diff/60001/third_party/WebKit/public/web/WebFrameWidget.h#newcode85 > ...
4 years, 5 months ago (2016-07-14 04:16:01 UTC) #28
tkent
lgtm
4 years, 5 months ago (2016-07-14 04:18:29 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150443002/80001
4 years, 5 months ago (2016-07-14 05:12:55 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/244932)
4 years, 5 months ago (2016-07-14 05:50:16 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150443002/80001
4 years, 5 months ago (2016-07-14 05:51:24 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/52713)
4 years, 5 months ago (2016-07-14 06:10:54 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150443002/100001
4 years, 5 months ago (2016-07-14 10:06:57 UTC) #41
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/255791)
4 years, 5 months ago (2016-07-14 10:48:45 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150443002/120001
4 years, 5 months ago (2016-07-15 04:48:32 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/221595)
4 years, 5 months ago (2016-07-15 05:20:31 UTC) #48
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-15 14:36:11 UTC) #49
sof
Wouldn't bringing the supplementable class defn into scope when defining the supplements take care of ...
4 years, 5 months ago (2016-07-25 09:19:28 UTC) #50
haraken
On 2016/07/25 09:19:28, sof wrote: > Wouldn't bringing the supplementable class defn into scope when ...
4 years, 5 months ago (2016-07-25 11:39:09 UTC) #51
sof
On 2016/07/25 11:39:09, haraken wrote: > On 2016/07/25 09:19:28, sof wrote: > > Wouldn't bringing ...
4 years, 5 months ago (2016-07-25 12:49:38 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150443002/140001
4 years, 4 months ago (2016-08-03 07:34:34 UTC) #55
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/240509)
4 years, 4 months ago (2016-08-03 07:46:01 UTC) #57
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150443002/160001
4 years, 4 months ago (2016-08-03 07:49:28 UTC) #60
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/266591)
4 years, 4 months ago (2016-08-03 08:23:00 UTC) #62
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150443002/220001
4 years, 4 months ago (2016-08-22 01:29:40 UTC) #67
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 02:11:22 UTC) #69
Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698