Issue 2132023002: Store the notification id as a string for Android notifications

Issue 2132023002: Store the notification id as a string for Android notifications (Closed)

Created:
4 years, 5 months ago by Miguel Garcia

Modified:
4 years, 5 months ago

Reviewers:
Peter Beverloo

CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@event_api

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Store the notification id as a string for Android notifications BUG=596161 Committed: https://crrev.com/e4c7e28299c938e1e365d23f99a2210b32dabb81 Cr-Commit-Position: refs/heads/master@{#404532}

Patch Set 2 : re-add TODO #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -100 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java	View	1	16 chunks	+46 lines, -52 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeIntentTest.java	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/notifications/notification_platform_bridge_android.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/notifications/notification_platform_bridge_android.cc	View	1	10 chunks	+24 lines, -38 lines	0 comments	Download

Depends on Patchset:

Issue 2093953002 Patch 180001

Messages

Total messages: 10 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Peter Beverloo

lgtm! https://chromiumcodereview.appspot.com/2132023002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java File chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java (left): https://chromiumcodereview.appspot.com/2132023002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java#oldcode688 chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java:688: // TODO(miguelg) make profile_id part of the tag. ...

4 years, 5 months ago (2016-07-08 16:14:38 UTC) #3

Miguel Garcia

https://codereview.chromium.org/2132023002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java File chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java (left): https://codereview.chromium.org/2132023002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java#oldcode688 chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java:688: // TODO(miguelg) make profile_id part of the tag. On ...

4 years, 5 months ago (2016-07-08 16:43:09 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132023002/20001

4 years, 5 months ago (2016-07-08 23:22:07 UTC) #7

commit-bot: I haz the power

4 years, 5 months ago (2016-07-08 23:30:10 UTC) #10

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/e4c7e28299c938e1e365d23f99a2210b32dabb81
Cr-Commit-Position: refs/heads/master@{#404532}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages