chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java - Issue 2132023002: Store the notification id as a string for Android notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java

Issue 2132023002: Store the notification id as a string for Android notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@event_api

Patch Set: re-add TODO Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeIntentTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java

index 8202494e484dbdb256bb499f3a9bc6a7aa4a0c31..4b3eed1e42f5228c0b6222a9cef9abfbfe85c03f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java

@@ -51,7 +51,7 @@ public class NotificationService extends IntentService {

@Override

public void onHandleIntent(final Intent intent) {

- if (!intent.hasExtra(NotificationConstants.EXTRA_PERSISTENT_NOTIFICATION_ID)

+ if (!intent.hasExtra(NotificationConstants.EXTRA_NOTIFICATION_ID)

|| !intent.hasExtra(NotificationConstants.EXTRA_NOTIFICATION_INFO_ORIGIN)

|| !intent.hasExtra(NotificationConstants.EXTRA_NOTIFICATION_INFO_TAG)) {

return;