chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeIntentTest.java - Issue 2132023002: Store the notification id as a string for Android notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeIntentTest.java

Issue 2132023002: Store the notification id as a string for Android notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@event_api

Patch Set: re-add TODO Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java ('k') | chrome/browser/notifications/notification_platform_bridge_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeIntentTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeIntentTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeIntentTest.java

index b5f5e78c8c59a6deaf77483a1c326dbd4e0b3e2d..1fe8efb5ad0602e3ae8a3b9f8af21f476b46e41c 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeIntentTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeIntentTest.java

@@ -101,7 +101,7 @@ public class NotificationPlatformBridgeIntentTest

.putExtra(EXTRA_NOTIFICATION_ID, NotificationPlatformBridge.PLATFORM_ID)

.putExtra(NotificationConstants.EXTRA_NOTIFICATION_TAG,

NotificationPlatformBridge.makePlatformTag(

- 42L /* persistentNotificationId */, "https://example.com",

+ "42" /* notificationId */, "https://example.com",

null /* tag */));

Preferences activity = ActivityUtils.waitForActivity(

@@ -137,9 +137,7 @@ public class NotificationPlatformBridgeIntentTest

Intent intent = new Intent(NotificationConstants.ACTION_CLICK_NOTIFICATION);

intent.setClass(context, NotificationService.Receiver.class);

- long persistentId = 42;

- intent.putExtra(NotificationConstants.EXTRA_PERSISTENT_NOTIFICATION_ID, persistentId);

+ intent.putExtra(NotificationConstants.EXTRA_NOTIFICATION_ID, "42");

intent.putExtra(NotificationConstants.EXTRA_NOTIFICATION_INFO_PROFILE_ID, "Default");

intent.putExtra(

NotificationConstants.EXTRA_NOTIFICATION_INFO_ORIGIN, "https://example.com");