Alter the native code generator to directly use

Alter the native code generator to directly use
 Dart_SetBooleanReturnValue
 Dart_SetIntReturnValue
 Dart_SetDoubleReturnValue

instead of 
 Dart_Handle retval = toDart(...); // Calls Dart_Boolean, Dart_NewInteger,
                                   // Dart_Double.
 Dart_SetReturnValue(args, retval);

R=vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25698

[vsm, 2013-07-31 14:59:19]

lgtm

https://chromiumcodereview.appspot.com/21156011/diff/1/tools/dom/scripts/syst...
File tools/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/21156011/diff/1/tools/dom/scripts/syst...
tools/dom/scripts/systemnative.py:910: set_return_value =
'Dart_SetReturnValue(args, %s)' % (to_dart_conversion)
Do we need to still test whether to_dart_conversion is non-null as in the old
code?

[siva, 2013-07-31 18:51:59]

https://chromiumcodereview.appspot.com/21156011/diff/1/tools/dom/scripts/syst...
File tools/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/21156011/diff/1/tools/dom/scripts/syst...
tools/dom/scripts/systemnative.py:910: set_return_value =
'Dart_SetReturnValue(args, %s)' % (to_dart_conversion)
All the toDart methods are expected to return Dart_Null() and not 0 when an
element is null. The check if (returnValue) is kind of bogus as it ends up not
setting the return value is some cases.

I have another CL that fixes the code in some of the Custom elements
that was return 0 instead of Dart_Null().

On 2013/07/31 14:59:19, vsm wrote:
> Do we need to still test whether to_dart_conversion is non-null as in the old
> code?

[siva, 2013-08-01 00:58:26]

Committed patchset #1 manually as r25698 (presubmit successful).