Alter the native code generator to directly use

tools/dom/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 881 matching lines @@
           '        $NATIVE_TYPE result = $FUNCTION_CALL;\n'
           '        if (isNull)\n'
           '            return;\n',
           NATIVE_TYPE=return_type_info.native_type(),
           FUNCTION_CALL=function_call)
         value_expression = 'result'
       else:
         value_expression = function_call
 
       # Generate to Dart conversion of C++ value.
-      to_dart_conversion = return_type_info.to_dart_conversion(value_expression, self._interface.id, ext_attrs)
+      if return_type_info.native_type() == 'bool':
+        set_return_value = 'Dart_SetBooleanReturnValue(args, %s)' % (value_expression)
+      elif return_type_info.native_type() == 'int':
+        set_return_value = 'Dart_SetIntegerReturnValue(args, %s)' % (value_expression)
+      elif return_type_info.native_type() == 'double':
+        set_return_value = 'Dart_SetDoubleReturnValue(args, %s)' % (value_expression)
+      else:
+        to_dart_conversion = return_type_info.to_dart_conversion(value_expression, self._interface.id, ext_attrs)
+        set_return_value = 'Dart_SetReturnValue(args, %s)' % (to_dart_conversion)

[vsm, 2013/07/31 14:59:19]

Do we need to still test whether to_dart_conversion is non-null as in the old
code?

[siva, 2013/07/31 18:51:59]

All the toDart methods are expected to return Dart_Null() and not 0 when an
element is null. The check if (returnValue) is kind of bogus as it ends up not
setting the return value is some cases.

I have another CL that fixes the code in some of the Custom elements
that was return 0 instead of Dart_Null().

On 2013/07/31 14:59:19, vsm wrote:

       invocation_emitter.Emit(
-        '        Dart_Handle returnValue = $TO_DART_CONVERSION;\n'
-        '        if (returnValue)\n'
-        '            Dart_SetReturnValue(args, returnValue);\n',
-        TO_DART_CONVERSION=to_dart_conversion)
+        '        $RETURN_VALUE;\n',
+        RETURN_VALUE=set_return_value)
 
   def _GenerateNativeBinding(self, idl_name, argument_count, dart_declaration,
       native_suffix, is_custom, emit_metadata=True):
     metadata = []
     if emit_metadata:
       metadata = self._metadata.GetFormattedMetadata(
           self._renamer.GetLibraryName(self._interface),
           self._interface, idl_name, '  ')
 
     native_binding = '%s_%s_%s' % (self._interface.id, idl_name, native_suffix)
@@ skipping 121 matching lines @@
             '    if (Dart_NativeFunction func = $CLASS_NAME::resolver(name, argumentCount))\n'
             '        return func;\n',
             CLASS_NAME=os.path.splitext(os.path.basename(path))[0])
 
 def _IsOptionalStringArgumentInInitEventMethod(interface, operation, argument):
   return (
       interface.id.endswith('Event') and
       operation.id.startswith('init') and
       argument.ext_attrs.get('Default') == 'Undefined' and
       argument.type.id == 'DOMString')