aura: Remove CreateOffscreenContext from ui::ContextFactory.

aura: Remove CreateOffscreenContext from ui::ContextFactory.

Drop this method since it is not needed in the interface anymore. In
order to do this, make the cc::FakeContextProvider externally available
so ui::Compositor can make use of it for tests, and revamp it to make
it slightly more general.

Depends on: https://codereview.chromium.org/22293003/

R=jbauman, piman
BUG=258625
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217202

[piman, 2013-07-30 20:15:10]

https://codereview.chromium.org/21026005/diff/5001/ui/compositor/compositor.cc
File ui/compositor/compositor.cc (right):

https://codereview.chromium.org/21026005/diff/5001/ui/compositor/compositor.c...
ui/compositor/compositor.cc:161: offscreen));
If we don't make it create the GrContext any more, won't this cause problems if
we try to use filters?

[danakj, 2013-07-30 20:32:08]

https://codereview.chromium.org/21026005/diff/5001/ui/compositor/compositor.cc
File ui/compositor/compositor.cc (right):

https://codereview.chromium.org/21026005/diff/5001/ui/compositor/compositor.c...
ui/compositor/compositor.cc:161: offscreen));
On 2013/07/30 20:15:10, piman wrote:
> If we don't make it create the GrContext any more, won't this cause problems
if
> we try to use filters?

Oh, this should be the in process ContextProvider shouldn't it..

[piman, 2013-07-30 20:42:02]

https://codereview.chromium.org/21026005/diff/5001/ui/compositor/compositor.cc
File ui/compositor/compositor.cc (right):

https://codereview.chromium.org/21026005/diff/5001/ui/compositor/compositor.c...
ui/compositor/compositor.cc:161: offscreen));
On 2013/07/30 20:32:08, danakj wrote:
> On 2013/07/30 20:15:10, piman wrote:
> > If we don't make it create the GrContext any more, won't this cause problems
> if
> > we try to use filters?
> 
> Oh, this should be the in process ContextProvider shouldn't it..

Yeah, I think that'd work fine. Quite possibly we don't need CreateContextCommon
for the offscreen case after that.

[danakj, 2013-07-30 20:42:56]

On Tue, Jul 30, 2013 at 4:42 PM, <piman@chromium.org> wrote:

>
> https://codereview.chromium.**org/21026005/diff/5001/ui/**
>
compositor/compositor.cc<https://codereview.chromium.org/21026005/diff/5001/ui/compositor/compositor.cc>
> File ui/compositor/compositor.cc (right):
>
> https://codereview.chromium.**org/21026005/diff/5001/ui/**
>
compositor/compositor.cc#**newcode161<https://codereview.chromium.org/21026005/diff/5001/ui/compositor/compositor.cc#newcode161>
> ui/compositor/compositor.cc:**161: offscreen));
> On 2013/07/30 20:32:08, danakj wrote:
>
>> On 2013/07/30 20:15:10, piman wrote:
>> > If we don't make it create the GrContext any more, won't this cause
>>
> problems
>
>> if
>> > we try to use filters?
>>
>
>  Oh, this should be the in process ContextProvider shouldn't it..
>>
>
> Yeah, I think that'd work fine. Quite possibly we don't need
> CreateContextCommon for the offscreen case after that.
>

Yep, that's what I'm doing :)


>
>
https://codereview.chromium.**org/21026005/<https://codereview.chromium.org/2...
>

[danakj, 2013-07-30 20:45:25]

PTAL

This is also awesome cuz I was worried about more tightly coupling TestContext3d
and FakeContextProvider, but now all consumers of the latter will also use the
former, so win.

[piman, 2013-07-30 20:56:18]

lgtm

[commit-bot: I haz the power, 2013-08-07 21:52:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/21026005/26001

[commit-bot: I haz the power, 2013-08-07 22:19:46]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[danakj, 2013-08-13 00:43:42]

ben@ please have a look: using the ContextFactory's ContextProvider in aura
bench.

[danakj, 2013-08-13 00:44:39]

ben@ please have a look: using the ContextFactory's ContextProvider in aura
bench.

[danakj, 2013-08-13 01:07:21]

+the not OOO owner for ui/aura/

[sadrul, 2013-08-13 01:18:16]

LGTM

https://codereview.chromium.org/21026005/diff/59001/ui/aura/bench/bench_main.cc
File ui/aura/bench/bench_main.cc (right):

https://codereview.chromium.org/21026005/diff/59001/ui/aura/bench/bench_main....
ui/aura/bench/bench_main.cc:213: OffscreenContextProviderForMainThread();
I assume this follows any special indentation rule for more-than-two-line
statements (if any).

[danakj, 2013-08-13 01:21:09]

Thanks!

https://codereview.chromium.org/21026005/diff/59001/ui/aura/bench/bench_main.cc
File ui/aura/bench/bench_main.cc (right):

https://codereview.chromium.org/21026005/diff/59001/ui/aura/bench/bench_main....
ui/aura/bench/bench_main.cc:213: OffscreenContextProviderForMainThread();
On 2013/08/13 01:18:17, sadrul wrote:
> I assume this follows any special indentation rule for more-than-two-line
> statements (if any).

I clang-formatted it now just in case.

[commit-bot: I haz the power, 2013-08-13 01:27:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/21026005/63001

[commit-bot: I haz the power, 2013-08-13 05:18:37]

Change committed as 217202