WebAPK: Move MainActivity#onCreate() to runtime library

WebAPK: Move MainActivity#onCreate() to runtime library

This CL decreases the amount of code in webapk/shell_apk.
webapk/shell_apk and webapk/common are the only Java files bundled in the
WebAPK. In order for the Java to updated, the WebAPK server needs to
download and install a new version of the WebAPK. Decreasing the amount of
code in webapk/shell_apk decreases how often new WebAPK versions will have
to be pushed to users.

BUG=623359
Committed: https://crrev.com/eca599f8cf531d066b41543e9403ffb2fabce489
Cr-Commit-Position: refs/heads/master@{#403552}

[pkotwicz, 2016-06-26 03:16:33]

Patchset #2 (id:20001) has been deleted

[pkotwicz, 2016-06-26 03:16:48]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2016-06-26 03:25:39]

Patchset #1 (id:40001) has been deleted

[pkotwicz, 2016-06-26 03:26:10]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2016-06-26 03:26:11]

Xi can you please take a look?

This CL depends on https://codereview.chromium.org/2094113002/

[Xi Han, 2016-06-27 18:27:08]

https://codereview.chromium.org/2101433002/diff/60001/chrome/android/webapk/l...
File
chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java
(right):

https://codereview.chromium.org/2101433002/diff/60001/chrome/android/webapk/l...
chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java:57:
private static final String KEY_APP_ICON_ID = "app_icon_id";
How about to put it in the WebApkConstants? So we will only keep one copy of the
 KEY_APP_ICON_ID, and will run into sync issue.

https://codereview.chromium.org/2101433002/diff/60001/chrome/android/webapk/s...
File
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkServiceFactory.java
(right):

https://codereview.chromium.org/2101433002/diff/60001/chrome/android/webapk/s...
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkServiceFactory.java:44:
HostBrowserClassLoader.getClassLoaderInstance(this,
WEBAPK_SERVICE_IMPL_CLASS_NAME);
Is it good to move the call to get ClassLoader in onCreate()?

[pkotwicz, 2016-06-27 20:44:28]

Xi can you please take another look?

In my latest patch set I synchronize access to
HostBrowserClassLoader#sClassLoader

https://codereview.chromium.org/2101433002/diff/60001/chrome/android/webapk/l...
File
chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java
(right):

https://codereview.chromium.org/2101433002/diff/60001/chrome/android/webapk/l...
chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java:57:
private static final String KEY_APP_ICON_ID = "app_icon_id";
I want to keep libs/common as small as possible. libs/common is hard to think
about. 

This scenario is possible:
ShellAPK uses an old version of libs/common (Request for new ShellAPK has been
sent to server)
runtime library uses a new version of libs/common

https://codereview.chromium.org/2101433002/diff/60001/chrome/android/webapk/s...
File
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkServiceFactory.java
(right):

https://codereview.chromium.org/2101433002/diff/60001/chrome/android/webapk/s...
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkServiceFactory.java:44:
HostBrowserClassLoader.getClassLoaderInstance(this,
WEBAPK_SERVICE_IMPL_CLASS_NAME);
It is not important that interacting with the WebAPK service is fast, so I do
not think that moving the HostBrowserClassLoader#getClassLoaderInstance()
invocation to onCreate() is helpful. I am also unsure whether moving the
invocation to onCreate() will speed things up.

[Xi Han, 2016-06-28 13:53:40]

lgtm

https://codereview.chromium.org/2101433002/diff/60001/chrome/android/webapk/l...
File
chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java
(right):

https://codereview.chromium.org/2101433002/diff/60001/chrome/android/webapk/l...
chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java:57:
private static final String KEY_APP_ICON_ID = "app_icon_id";
On 2016/06/27 20:44:28, pkotwicz wrote:
> I want to keep libs/common as small as possible. libs/common is hard to think
> about. 
> 
> This scenario is possible:
> ShellAPK uses an old version of libs/common (Request for new ShellAPK has been
> sent to server)
> runtime library uses a new version of libs/common

It makes sense.

https://codereview.chromium.org/2101433002/diff/60001/chrome/android/webapk/s...
File
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkServiceFactory.java
(right):

https://codereview.chromium.org/2101433002/diff/60001/chrome/android/webapk/s...
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkServiceFactory.java:44:
HostBrowserClassLoader.getClassLoaderInstance(this,
WEBAPK_SERVICE_IMPL_CLASS_NAME);
On 2016/06/27 20:44:28, pkotwicz wrote:
> It is not important that interacting with the WebAPK service is fast, so I do
> not think that moving the HostBrowserClassLoader#getClassLoaderInstance()
> invocation to onCreate() is helpful. I am also unsure whether moving the
> invocation to onCreate() will speed things up.

I don't have strong opinion on this, it seems ok since getClassLoaderInstance
returns the static instance directly if it is not null.

[pkotwicz, 2016-07-01 21:03:55]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-07-01 21:03:56]

The patchset sent to the CQ was uploaded after l-g-t-m from hanxi@chromium.org
Link to the patchset: https://codereview.chromium.org/2101433002/#ps120001
(title: "Merge branch 'master' into webapk_more_meta2_loader")

[commit-bot: I haz the power, 2016-07-01 21:04:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pkotwicz, 2016-07-01 21:09:00]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2016-07-01 21:21:45]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-07-01 21:21:45]

The patchset sent to the CQ was uploaded after l-g-t-m from hanxi@chromium.org
Link to the patchset: https://codereview.chromium.org/2101433002/#ps140001
(title: "Merge branch 'master' into webapk_more_meta2_loader")

[commit-bot: I haz the power, 2016-07-01 21:22:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 22:30:53]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2016-07-01 22:31:01]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 22:32:24]

Description was changed from

==========
WebAPK: Move MainActivity#onCreate() to runtime library

This CL decreases the amount of code in webapk/shell_apk.
webapk/shell_apk and webapk/common are the only Java files bundled in the
WebAPK. In order for the Java to updated, the WebAPK server needs to
download and install a new version of the WebAPK. Decreasing the amount of
code in webapk/shell_apk decreases how often new WebAPK versions will have
to be pushed to users.

BUG=623359
==========

to

==========
WebAPK: Move MainActivity#onCreate() to runtime library

This CL decreases the amount of code in webapk/shell_apk.
webapk/shell_apk and webapk/common are the only Java files bundled in the
WebAPK. In order for the Java to updated, the WebAPK server needs to
download and install a new version of the WebAPK. Decreasing the amount of
code in webapk/shell_apk decreases how often new WebAPK versions will have
to be pushed to users.

BUG=623359

Committed: https://crrev.com/eca599f8cf531d066b41543e9403ffb2fabce489
Cr-Commit-Position: refs/heads/master@{#403552}
==========

[commit-bot: I haz the power, 2016-07-01 22:32:25]

Patchset 5 (id:??) landed as
https://crrev.com/eca599f8cf531d066b41543e9403ffb2fabce489
Cr-Commit-Position: refs/heads/master@{#403552}