Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Unified Diff: chrome/android/webapk/libs/runtime_library/src/README

Issue 2101433002: WebAPK: Move MainActivity#onCreate() to runtime library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_more_meta2_loader Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/webapk/libs/runtime_library/src/README
diff --git a/chrome/android/webapk/libs/runtime_library/src/README b/chrome/android/webapk/libs/runtime_library/src/README
index 04af7d52ce31db0b32a41eeff72c237d444810d1..731e3ab0e0c379bfa88618fcf9da339dc39ce9de 100644
--- a/chrome/android/webapk/libs/runtime_library/src/README
+++ b/chrome/android/webapk/libs/runtime_library/src/README
@@ -1,13 +1,16 @@
-The runtime library contains the implementation of the Web APK service. It
-implements functionality which Chrome delegates to the Web APK such as
-displaying notifications. The library is loaded by a ShellAPK which
-contains the Web APK's manifest and code to load the runtime library.
+The runtime library contains:
+1) Implementation of the WebAPK service. The service implements functionality
+which Chrome delegates to the WebAPK such as displaying notifications.
+2) Logic to send intent to Chrome to launch Chrome in WebAPK mode.
-The latest version of the runtime library is
-extracted from Chrome's APK by the ShellAPK when the Web APK service is created.
-Since the ShellAPK is updated asynchronously, the runtime library may run within
-an old ShellAPK. For instance, the ShellAPK's Android manifest may be missing
-some of the permissions that the runtime library is expecting.
+The library is loaded by a ShellAPK which contains the WebAPK's manifest and
+code to load the runtime library.
+
+The latest version of the runtime library is extracted from Chrome's APK by the
+ShellAPK when it is launched. Since the ShellAPK is updated asynchronously, the
+runtime library may run within an old ShellAPK. For instance, the ShellAPK's
+Android manifest may be missing some of the permissions that the runtime library
+is expecting.
The number in runtime_library_version.gni must be incremented whenever the
runtime library is updated. The WebAPK re-extracts the runtime library from the

Powered by Google App Engine
This is Rietveld 408576698