Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2091023007: Add the mini_installer_syzygy GN target. (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the mini_installer_syzygy GN target. This moves most of the mini_installer GN code into a template so it can be reused to generate the mini_installer_syzygy target. It almost works except that syzygy\mini_installer.exe (which is an archive) contain 'syzygy/chrome.packed.7z' instead of 'chrome.packed.7z', I'm not sure why (the flags passed to create_installer_archive.py are the same than with GYP). I'm not so familiar with GN so there's probably a better/cleaner way to do this. TBR=sebmarchand@chromium.org, brucedawson@chromium.org, brettw@chromium.org BUG=525752 patch from issue 2085813004 at patchset 140001 (http://crrev.com/2085813004#ps140001) Committed: https://crrev.com/64aa48239178993a80ef8348f0a5b14e40358e96 Cr-Commit-Position: refs/heads/master@{#402080}

Patch Set 1 : original patchset from http://crrev.com/2085813004#ps140001 #

Patch Set 2 : update w/ review feedback, fix visibility #

Patch Set 3 : consolidate syzygy_optimize logic #

Patch Set 4 : fix import of visual_studio_version #

Patch Set 5 : rework location of is_win_fastlink, fix full_wpo_on_official while I'm at it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -166 lines) Patch
M build/config/compiler/compiler.gni View 1 2 3 4 3 chunks +25 lines, -11 lines 0 comments Download
M build/config/win/visual_studio_version.gni View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/installer/mini_installer/BUILD.gn View 1 2 3 chunks +150 lines, -119 lines 0 comments Download
M chrome/tools/build/win/syzygy/BUILD.gn View 1 12 chunks +50 lines, -28 lines 0 comments Download
M third_party/kasko/kasko.gni View 1 chunk +4 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (11 generated)
Dirk Pranke
piggybacking off of brettw@'s lgtm on the other CL, and landing so that we can ...
4 years, 6 months ago (2016-06-25 22:58:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091023007/40001
4 years, 6 months ago (2016-06-25 22:58:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091023007/60001
4 years, 6 months ago (2016-06-25 23:20:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/26950) ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-25 23:22:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091023007/100001
4 years, 5 months ago (2016-06-26 15:26:05 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 5 months ago (2016-06-26 16:24:02 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-06-26 16:26:11 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/64aa48239178993a80ef8348f0a5b14e40358e96
Cr-Commit-Position: refs/heads/master@{#402080}

Powered by Google App Engine
This is Rietveld 408576698