Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2094103002: Add All_syzygy target to GN build. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@mini_installer_syzygy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add All_syzygy target to GN build. TBR=brettw@chromium.org, sebmarchand@chromium.org, brucedawson@chromium.org BUG=525752 Committed: https://crrev.com/bad56d4bfc40dedfc24ee06f64abfc7f54fd3148 Cr-Commit-Position: refs/heads/master@{#402081}

Patch Set 1 #

Patch Set 2 : remove unneeded import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M BUILD.gn View 1 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
Dirk Pranke
4 years, 5 months ago (2016-06-26 16:13:28 UTC) #1
commit-bot: I haz the power
This CL has an open dependency (Issue 2091023007 Patch 100001). Please resolve the dependency and ...
4 years, 5 months ago (2016-06-26 16:13:38 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094103002/20001
4 years, 5 months ago (2016-06-26 16:33:22 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-26 17:49:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094103002/20001
4 years, 5 months ago (2016-06-26 18:02:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-26 18:06:52 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-26 18:08:41 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bad56d4bfc40dedfc24ee06f64abfc7f54fd3148
Cr-Commit-Position: refs/heads/master@{#402081}

Powered by Google App Engine
This is Rietveld 408576698